kangpinghuang commented on a change in pull request #2471: add block split
bloom filter
URL: https://github.com/apache/incubator-doris/pull/2471#discussion_r358650651
##########
File path: be/src/olap/rowset/beta_rowset_writer.cpp
##########
@@ -161,6 +161,7 @@ RowsetSharedPtr BetaRowsetWriter::build() {
OLAPStatus BetaRowsetWriter::_create_segment_writer() {
auto path = BetaRowset::segment_file_path(_context.rowset_path_prefix,
_context.rowset_id, _num_segment);
segment_v2::SegmentWriterOptions writer_options;
+ writer_options.has_bf_for_unique_agg_column = _context.version.first == 0;
Review comment:
change it to whether_to_filter_value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
