imay commented on a change in pull request #2294: Add convert tablet rowset type
URL: https://github.com/apache/incubator-doris/pull/2294#discussion_r355448848
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -841,12 +842,16 @@ private void createJob(long dbId, OlapTable olapTable,
Map<Long, LinkedList<Colu
// property 3: timeout
long timeoutSecond = PropertyAnalyzer.analyzeTimeout(propertyMap,
Config.alter_table_timeout_second);
+ boolean changeStorageFormat =
PropertyAnalyzer.analyzeStorageFormat(propertyMap);
// create job
Catalog catalog = Catalog.getCurrentCatalog();
long jobId = catalog.getNextId();
SchemaChangeJobV2 schemaChangeJob = new SchemaChangeJobV2(jobId, dbId,
olapTable.getId(), olapTable.getName(), timeoutSecond * 1000);
schemaChangeJob.setBloomFilterInfo(hasBfChange, bfColumns, bfFpp);
+ if (changeStorageFormat) {
Review comment:
Add some comment for the reason of this code, because it would be difficult
to understand in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
