imay commented on a change in pull request #2309: Date format support java date 
style "yyyy-MM-dd HH:mm:ss"
URL: https://github.com/apache/incubator-doris/pull/2309#discussion_r351314315
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
 ##########
 @@ -596,6 +596,20 @@ public void analyzeImpl(Analyzer analyzer) throws 
AnalysisException {
             throw new 
AnalysisException(getFunctionNotFoundError(collectChildReturnTypes()));
         }
 
+        if (fnName.getFunction().equals("from_unixtime")) {
 
 Review comment:
   ```suggestion
           if (fnName.getFunction().equalsIgnoreCase("from_unixtime")) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to