imay commented on a change in pull request #2296: Ignore non-existent tablet in
clear_transaction_task()
URL: https://github.com/apache/incubator-doris/pull/2296#discussion_r350663052
##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -495,10 +491,12 @@ void StorageEngine::clear_transaction_task(const
TTransactionId transaction_id,
// each tablet
for (auto& tablet_info : tablet_infos) {
// should use tablet uid to ensure clean txn correctly
- TabletSharedPtr tablet =
_tablet_manager->get_tablet(tablet_info.first.tablet_id,
+ TabletSharedPtr tablet =
_tablet_manager->get_tablet(tablet_info.first.tablet_id,
tablet_info.first.schema_hash, tablet_info.first.tablet_uid);
+ // The tablet may be dropped or altered, leave a INFO log and go
on process other tablet
if (tablet == nullptr) {
- return;
+ LOG(INFO) << "tablet is no longer exist. tablet_id=" <<
tablet_info.first.tablet_id;
Review comment:
LOG schema hash and tablet_uid to be more clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
