morningman commented on a change in pull request #2182: Sending clear txn task 
explicitly after transaction being aborted
URL: https://github.com/apache/incubator-doris/pull/2182#discussion_r345198306
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -225,6 +235,7 @@ OLAPStatus TxnManager::commit_txn(
         WriteLock wrlock(&_txn_map_lock);
         TabletTxnInfo load_info(load_id, rowset_ptr);
         _txn_tablet_map[key][tablet_info] = load_info;
+        _insert_txn_partition_map(transaction_id, partition_id);
 
 Review comment:
   No, commit_txn() will be called when BE starts. So we need to rebuild 
_insert_txn_partition_map alongside with _txn_tablet_map.
   And also, _txn_partition_map support to add same elements multi times, 
because it is a map with a set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to