wangbo commented on issue #2075: Segment v2 stream load core dump(#2037) URL: https://github.com/apache/incubator-doris/pull/2075#issuecomment-547235180 > 1. We make BitShuffleBuilder finish's return slice is same with what it will release. Then there is no need to add finish_and_release. I think it's better to keep all build method having the same semantics;And other PageBuilder using fastring as buffer may meet the same question.Just fix BitShuffleBuilder is not enough. > 2. We remove release interface and keep finish and finish_and_release. Because if we can't keep release and finish consistent, it will lead to other problems. There is two situation to get PageBuilder's page: 1. Caller maintains page, caller must call finish and release,it seems that using release to get result is better. 2. PageBuilder maintains page,caller using page just for copy and read,caller call finish is enough. And I don't understand what does "Because if we can't keep release and finish consistent, it will lead to other problems" mean
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
