kangpinghuang commented on a change in pull request #2055: add delete state of 
row block v2 for performance
URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r339385741
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
 ##########
 @@ -52,13 +52,14 @@ SegmentIterator::~SegmentIterator() {
 
 Status SegmentIterator::_init() {
     DorisMetrics::segment_read_total.increment(1);
+    RETURN_IF_ERROR(_init_column_iterators());
 
 Review comment:
   hi dayue, here just init return columns, I think there is no need to call 
_prepare_seek.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to