iampratap7997-dot commented on code in PR #17983:
URL:
https://github.com/apache/dolphinscheduler/pull/17983#discussion_r2828336086
##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.4.0_schema/mysql/dolphinscheduler_ddl.sql:
##########
@@ -25,7 +25,7 @@ ALTER TABLE `t_ds_task_group_queue` ADD KEY
`idx_workflow_instance_id` (`workflo
-- ----------------------------
CREATE TABLE IF NOT EXISTS `t_ds_serial_command` (
`id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key',
- `workflow_definition_code` int(11) NOT NULL COMMENT 'workflow definition
code',
+ `workflow_definition_code` bigint(20) NOT NULL COMMENT 'workflow definition
code',
Review Comment:
> Please don't change the 3.4.0 ddl, since this version has been released,
we should alter the column at 3.4.1 ddl.
Reverted changes in 3.4.0 schema and moved the column modification to 3.4.1
upgrade DDL as suggested.
Please review again.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
