ruanwenjun commented on code in PR #17856:
URL:
https://github.com/apache/dolphinscheduler/pull/17856#discussion_r2810450313
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskCallBack.java:
##########
@@ -26,4 +27,6 @@ public interface TaskCallBack {
// todo:The pid should put into runtime context
@Deprecated
void updateTaskInstanceInfo(int taskInstanceId);
+
+ void sendAlert(int groupId, String title, String content, AlertType
alertType);
Review Comment:
Don't add this at `TaskCallBack`, you can see `Deprecated` at
updateTaskInstanceInfo.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractTask.java:
##########
@@ -58,7 +58,7 @@ public abstract class AbstractTask {
protected boolean needAlert = false;
- protected TaskAlertInfo taskAlertInfo;
+ protected TaskResultAlertInfo taskResultAlertInfo;
Review Comment:
Please don't add this into `AbstractTask`, this should only used at SqlTask?
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java:
##########
@@ -66,9 +66,9 @@ public class SqlParameters extends AbstractParameters {
private int sqlType;
/**
- * send email
+ * send alert
*/
- private Boolean sendEmail;
+ private Boolean sendAlert;
Review Comment:
Do not break compatibility casually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
