asadjan4611 opened a new pull request, #17951: URL: https://github.com/apache/dolphinscheduler/pull/17951
## What changes were proposed in this pull request? This PR adds a loading skeleton/placeholder for the workflow definition list during data fetch operations, addressing issue #17948. ### Changes: - Added `NSkeleton` component from Naive UI to display loading placeholder - Implemented conditional rendering to show skeleton during initial load, search, and pagination when no data exists - Set table `loading` prop to `false` to prevent triggering global loading indicators - Added comprehensive comments and documentation explaining the implementation ### Implementation Details: - Skeleton displays when `loadingRef === true` AND `tableData` is empty/null - Skeleton repeat count matches page size for visual consistency - Height set to 400px to accommodate multiple skeleton rows - Uses Naive UI's animated shimmer effect ### Benefits: - Improved perceived performance with immediate visual feedback - Better UX during slow network connections - Clear distinction between loading, empty, and error states - Isolated loading state (doesn't affect other components like navbar) ## Related issue(s) Closes #17948 ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Testing - [x] Tested skeleton display during initial page load - [x] Tested skeleton display during search with no results - [x] Tested skeleton display during pagination to empty pages - [x] Verified no global loading indicators are triggered - [x] Verified navbar/profile section is unaffected ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
