ruanwenjun commented on code in PR #17811:
URL:
https://github.com/apache/dolphinscheduler/pull/17811#discussion_r2637532401
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -130,10 +134,10 @@ public DataSource createDataSource(User loginUser,
BaseDataSourceParamDTO dataso
}
/**
- * updateWorkflowInstance datasource
+ * update datasource
Review Comment:
It's better to delete this kind of comment, since it doesn't contain any
useful information.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -167,6 +171,9 @@ public DataSource updateDataSource(User loginUser,
BaseDataSourceParamDTO dataSo
connectionParam.setPassword(oldParams.path(Constants.PASSWORD).asText());
}
+ // check connect
+ checkConnection(dataSource.getType(), connectionParam);
+
Review Comment:
This should not be mandatory.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java:
##########
@@ -107,8 +107,12 @@ public DataSource createDataSource(User loginUser,
BaseDataSourceParamDTO dataso
if (checkDescriptionLength(datasourceParam.getNote())) {
throw new ServiceException(Status.DESCRIPTION_TOO_LONG_ERROR);
}
+
ConnectionParam connectionParam =
DataSourceUtils.buildConnectionParams(datasourceParam);
+ // check connect
+ checkConnection(datasourceParam.getType(), connectionParam);
+
Review Comment:
This should not be mandatory. Sometimes our API service may not be able to
access the data source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
