github-advanced-security[bot] commented on code in PR #17790:
URL:
https://github.com/apache/dolphinscheduler/pull/17790#discussion_r2616043030
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -198,9 +181,7 @@
*/
private String buildDataxJsonFile(Map<String, Property> paramsMap) throws
Exception {
// generate json
- String fileName = String.format("%s/%s_job.json",
- taskExecutionContext.getExecutePath(),
- taskExecutionContext.getTaskAppId());
+ String fileName = String.format("%s/%s_job.json",
taskRequest.getExecutePath(), taskRequest.getTaskAppId());
Review Comment:
## Deprecated method or constructor invocation
Invoking [TaskExecutionContext.getTaskAppId](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5594)
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTask.java:
##########
@@ -133,9 +119,7 @@
*/
private String buildChunJunJsonFile(Map<String, Property> paramsMap)
throws Exception {
// generate json
- String fileName = String.format("%s/%s_job.json",
- taskExecutionContext.getExecutePath(),
- taskExecutionContext.getTaskAppId());
+ String fileName = String.format("%s/%s_job.json",
taskRequest.getExecutePath(), taskRequest.getTaskAppId());
Review Comment:
## Deprecated method or constructor invocation
Invoking [TaskExecutionContext.getTaskAppId](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5593)
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelTask.java:
##########
@@ -208,8 +191,8 @@
}
private String buildConfigFilePath() {
- return String.format("%s/seatunnel_%s.%s",
taskExecutionContext.getExecutePath(),
- taskExecutionContext.getTaskAppId(), formatDetector());
+ return String.format("%s/seatunnel_%s.%s",
taskRequest.getExecutePath(),
+ taskRequest.getTaskAppId(), formatDetector());
Review Comment:
## Deprecated method or constructor invocation
Invoking [TaskExecutionContext.getTaskAppId](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5596)
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-hivecli/src/main/java/org/apache/dolphinscheduler/plugin/task/hivecli/HiveCliTask.java:
##########
@@ -184,8 +180,8 @@
}
protected String generateSqlScriptFile(String rawScript) {
- String scriptFileName = String.format("%s/%s_node.sql",
taskExecutionContext.getExecutePath(),
- taskExecutionContext.getTaskAppId());
+ String scriptFileName = String.format("%s/%s_node.sql",
taskRequest.getExecutePath(),
+ taskRequest.getTaskAppId());
Review Comment:
## Deprecated method or constructor invocation
Invoking [TaskExecutionContext.getTaskAppId](1) should be avoided because it
has been deprecated.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5595)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
