ruanwenjun commented on code in PR #17523:
URL: 
https://github.com/apache/dolphinscheduler/pull/17523#discussion_r2384463891


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/utils/TaskExecutionContextUtils.java:
##########
@@ -108,4 +111,21 @@ public static ResourceContext 
downloadResourcesIfNeeded(TaskChannel taskChannel,
         return resourceContext;
     }
 
+    public static void clearTaskInstanceWorkingDirectory(TaskExecutionContext 
taskExecutionContext) {
+        boolean isDevelopment = 
PropertyUtils.getBoolean(Constants.DEVELOPMENT_STATE, true);
+        if (!isDevelopment) {

Review Comment:
   Move this in `finalizeTask` method, the utils only provide the delete logic 
here, then you can easilly test this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to