npofsi commented on code in PR #17402:
URL:
https://github.com/apache/dolphinscheduler/pull/17402#discussion_r2329476595
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/workflow/BaseWorkflowE2ETest.java:
##########
@@ -167,8 +202,15 @@ protected TaskInstanceTab.Row
untilTaskInstanceFailed(String workflowName, Strin
return await()
.until(() -> {
browser.navigate().refresh();
- List<TaskInstanceTab.Row> taskInstances = projectPage
- .goToTab(TaskInstanceTab.class)
+
+ await().ignoreException(NoSuchElementException.class)
+ .untilAsserted(() -> assertThat(browser)
+ .as("task instance is not found")
+ .matches(it ->
it.findElement(By.className("n-menu-item-content")).isDisplayed()));
+ TaskInstanceTab taskInstanceTab = projectPage
+ .goToTab(TaskInstanceTab.class);
+
+ List<TaskInstanceTab.Row> taskInstances = taskInstanceTab
Review Comment:
The new awaits added to E2E are ensuring the behaviour stability. Maybe I
need some help here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
