njnu-seafish opened a new pull request, #17437:
URL: https://github.com/apache/dolphinscheduler/pull/17437
<!--Thanks very much for contributing to Apache DolphinScheduler, we are
happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
close #17436
## Brief change log
1. add string blank check
2. remove redundant cancelApplication call
## Verify this pull request
After fixing the bug, timeout kill logs:
2025-08-21 09:30:25.259 INFO [WorkerRpcServer-methodInvoker-155] - Publish
TaskExecutorKillLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739825259,
"type" : "KILL"
}
2025-08-21 09:30:25.302 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Begin killing task instance, processId: 1115493
2025-08-21 09:30:25.826 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
prepare to parse pid, raw pid string:
sudo(1115493)---1341.sh(1115497)---sleep(1115570)
2025-08-21 09:30:26.370 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Sending SIGINT to process group: 1115493 1115497 1115570, command: sudo -u
dolphinscheduler -i kill -s SIGINT 1115493 1115497 1115570
2025-08-21 09:30:37.408 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] - Kill
command: sudo -u dolphinscheduler -i kill -s SIGINT 1115493 1115497 1115570,
timed out, still running PIDs: 1115493 1115497 1115570
2025-08-21 09:30:37.961 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Sending SIGTERM to process group: 1115493 1115497 1115570, command: sudo -u
dolphinscheduler -i kill -s SIGTERM 1115493 1115497 1115570
2025-08-21 09:30:38.156 ERROR [exclusive-task-executor-container-worker-1] -
process has failure due to timeout kill, the timeout value is:60, the
taskTimeoutStrategy is:FAILED
2025-08-21 09:30:38.157 INFO [exclusive-task-executor-container-worker-1] -
process has killed. execute path:/data01/dolphinscheduler/exec/process/1341,
processId:1115493 ,exitStatusCode:-1 ,processWaitForStatus:false
,processExitValue:143
2025-08-21 09:30:38.157 INFO [exclusive-task-executor-container-worker-1] -
Publish TaskExecutorFailedLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739838157,
"type" : "FAILED",
"workflowInstanceId" : 1273,
"workflowInstanceHost" : "192.168.30.11:5678",
"taskInstanceHost" : "192.168.30.121:1234",
"appIds" : null,
"endTime" : 1755739838157,
"latestReportTime" : null
}
2025-08-21 09:30:38.157 INFO [exclusive-task-executor-container-worker-1] -
Publish TaskExecutorFinalizeLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739838157,
"type" : "FINALIZE"
}
2025-08-21 09:30:38.676 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Successfully killed process tree using SIGTERM, processId: 1115493
2025-08-21 09:30:38.676 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Process tree for task: 1341 is killed or already finished, pid: 1115493
2025-08-21 09:30:38.677 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] - Get
appIds from worker 192.168.30.121:1234, taskLogPath:
/data01/dolphinscheduler/20250821/149143631011392/7/1273/1341.log
2025-08-21 09:30:38.677 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Start finding appId in
/data01/dolphinscheduler/20250821/149143631011392/7/1273/1341.log, fetch way:
log
2025-08-21 09:30:38.677 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] - The
appId is empty
2025-08-21 09:30:38.677 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-22] -
Success fire TaskExecutorKillLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739825259,
"type" : "KILL"
}
2025-08-21 09:30:38.718 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-20] -
Success fire TaskExecutorFailedLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739838157,
"type" : "FAILED",
"workflowInstanceId" : 1273,
"workflowInstanceHost" : "192.168.30.11:5678",
"taskInstanceHost" : "192.168.30.121:1234",
"appIds" : null,
"endTime" : 1755739838157,
"latestReportTime" : null
}
2025-08-21 09:30:38.768 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-21] -
************************************************************************************************
********************************* Finalize task instance
************************************
***********************************************************************************************
2025-08-21 09:30:38.768 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-21] -
FINALIZE_SESSION
2025-08-21 09:30:38.768 INFO
[PhysicalTaskExecutorEventBusCoordinator-eventbus-coordinator-worker-21] -
Success fire TaskExecutorFinalizeLifecycleEvent: {
"taskInstanceId" : 1341,
"eventCreateTime" : 1755739838157,
"type" : "FINALIZE"
}
## Pull Request Notice
[Pull Request
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to
`docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
