Gallardot commented on code in PR #17340:
URL:
https://github.com/apache/dolphinscheduler/pull/17340#discussion_r2284403459
##########
dolphinscheduler-api/src/main/resources/application.yaml:
##########
@@ -216,6 +220,29 @@ security:
callbackUrl: ""
iconUri: ""
provider: google
+ oidc:
+ enable: true
+ providers:
+ # registrationId used in URLs and internal mapping
+ keycloak:
+ display-name: "Login with Keycloak" # Text for UI Button
+ issuer-uri: http://keycloak:8080/realms/dolphinscheduler
+ icon-uri: "/images/providers-icon/keycloak.png"
Review Comment:
Just a example?
##########
dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/resources/docker/oidc-login/init-sql/dolphinscheduler_mysql.sql:
##########
@@ -0,0 +1,1370 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+-- ----------------------------
+-- Table structure for QRTZ_JOB_DETAILS
+-- ----------------------------
+DROP TABLE IF EXISTS `QRTZ_JOB_DETAILS`;
Review Comment:
Is this file copy from
'https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql'
?
Would it be better to create a soft link? There is no need to maintain two
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
