dill21yu commented on issue #16706:
URL: 
https://github.com/apache/dolphinscheduler/issues/16706#issuecomment-2995190427

   > > Add several 
types:"anyTimeToday,anyTimeLast1Days,anyTimeLast2Days,anyTimeLast3Days,anyTimeLast7Days,anyTimeThisWeek,anyTimeLastWeek,anyTimeThisMonth,anyTimeLastMonth"
   > > Add a parameter in calculateResultForTasks to determine if the task 
execution result is "any time in a period of time". If any workflow instance is 
successful during the time period, it will return a success status
   > 
   > At present, we have two different types of dependency cycles.
   > 
   > 1. Individual cycle dependence, such as one hour, last day, etc...
   > 2. Continuous time dependence, for example, last month means a month in a 
row.
   > 
   > Adding anytime types directly to the status quo will lead to confusion 
among users. So I suggest that the naming methods of these types be combed 
again.
   > 
   > 1. Individual cycle dependence
   >    1.1 `currentHour` stay as it is.
   >    1.2 Using `lastNHours` to represent any hours and use expression to 
parse it.
   >    1.3 `lastWeek` stay as it is.
   >    1.4 `lastMonday` stay as it is.
   >    1.5 `lastTuesday` stay as it is.
   >    1.6 `lastWednesday` stay as it is.
   >    1.7 `lastThursday` stay as it is.
   >    1.8 `lastFriday` stay as it is.
   >    1.9 `lastSaturday` stay as it is.
   >    1.10 `lastSunday` stay as it is.
   >    1.11 `thisMonth` newly added.
   >    1.12 Using `lastNMonth` to represent any month and use expression to 
parse it.
   > 2. Continuous time dependence
   >    2.1 `thisMonthPeriod` to represent a continuous month.
   >    2.2 `last1MonthPeriod` to represent a specified continuous month and 
use expression to parse it.
   > 
   > This is just my initial idea. If you have a better idea, please feel free 
to point it out. [@dill21yu](https://github.com/dill21yu)
   
   I agree with your idea. The new 'thisMonthPeriod' means that the dependency 
condition only needs to satisfy any successful instance within this month. 
Besides 'thisMonthPeriod' and 'last1MonthPeriod', do we also need to add types 
like 'last1WeekPeriod' or others? Can this issue be assigned to me to work on? 
@SbloodyS 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to