reele commented on PR #17155: URL: https://github.com/apache/dolphinscheduler/pull/17155#issuecomment-2840968175
> Can we remove `GlobalTaskDispatchWaitingQueue` and `GlobalTaskDispatchWaitingQueueLooper`, this queue is used to handle the delay time, but bring some extra problems, e.g. there are existing many thread to deal with the task lifecycle in master, we need to do extra concurrency control, e.g. one task is in dispatching, and then receive a kill event. > > Since `TaskDispatchLifecycleEvent` is already an `DelayEvent` so we can directly set the delay time to it, then we can removed `TimeBasedTaskExecutionRunnableComparableEntry` and `WorkerGroupTaskDispatcher`. We directly use `ITaskExecutorClient` to dispatch task in `dispatchEventAction`, if dispatch failed then regenerate a `TaskDispatchLifecycleEvent` with retry delay time. i'll have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
