ruanwenjun commented on code in PR #17112:
URL:
https://github.com/apache/dolphinscheduler/pull/17112#discussion_r2034325982
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/executor/workflow/StopWorkflowInstanceExecutorDelegate.java:
##########
@@ -95,6 +95,7 @@ void stopInMaster(WorkflowInstance workflowInstance) {
} catch (ServiceException e) {
throw e;
} catch (Exception e) {
+ log.error("WorkflowInstance stop failed, workflowInstanceId: {},
workflowInstanceName: {}", workflowInstance.getId(),
workflowInstance.getName(), e);
Review Comment:
Ok, I got you, since ServiceException are seems as expected exception,
although it contains the origin stack, but will not log, so we need to change
the aspect code to log the exception stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
