SbloodyS commented on code in PR #16784:
URL: 
https://github.com/apache/dolphinscheduler/pull/16784#discussion_r1833819008


##########
dolphinscheduler-ui/src/views/datasource/list/use-form.ts:
##########
@@ -269,6 +269,15 @@ export function useForm(id?: number) {
     } else {
       state.showPrincipal = false
     }
+
+    state.showRestEndpoint = false
+    state.showNamespace = false
+    state.showKubeConfig = false
+    state.showAccessKeyId = false
+    state.showAccessKeySecret = false
+    state.showRegionId = false
+    state.showEndpoint = false

Review Comment:
   It's better put these into each type's else logic so that it can be better 
maintained.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to