reele commented on PR #16776: URL: https://github.com/apache/dolphinscheduler/pull/16776#issuecomment-2459710122
> Add schedule time to sub workflow is very strange, the parent schedule time doesn't relate to sub workflow, like we don't add a schedule time to task. If we add schedule time to sub workflow, it would be better we also add schedule time in task. This may be a problem with our use of schedule time, we should be able to get the schedule time during workflow runtime, no matter it is a task or sub workflow. Allow task nodes to access initial runtime parameters, either by storing the parameters directly or by recording where to retrieve them. However, the multi-layer `sub-workflow` scheduling relationship complicates the parameter retrieval process, especially during the `master`'s `failover` process (currently, it doesn't restore tasks through the scheduling relationship). This is essentially the same issue as recording `command-param`. if we aim for a purely paradigmatic approach, we should treat `command` as an independent entity and only store the `command_id` in the top-level `workflow_instance`. Then, tasks in sub-workflows would need to recursively traverse both `relation_workflow_instance` and `workflow_task_relation` to locate the top-level `workflow_instance` and subsequently the `command` the key lies in balancing the distribution of information to optimize efficiency, stability, and operability. so i still want to know what your thoughts are for the next step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
