binitshrest commented on PR #16593: URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2409818560
> > @ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed. > > @binitshrest Yes, the ci has passed. But there are some extra things need to do. > > 1. Please remove two license files > > ``` > `dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-api-2.11.2.txt` > `dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-core-2.11.2.txt` > ``` > > Since you have removed these from LICENSE, and we really don't rely on these, good job, you have solved a new problem. 2. I am not sure if we need to add exclusion in all place, I add comment. Since once we add these, it will be hard to remove in the future, my experience is we only need to exclude these in dependencymanagement. It's need to have a try. Yes, Sir. We don't need to add that exclusion code in all place. I saw in this morning. Once i put that exclusion in root dependency. It will remove from all. I am not sure if i should remove from test scope . I will make also some changes what you have said earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
