ruanwenjun commented on PR #16683: URL: https://github.com/apache/dolphinscheduler/pull/16683#issuecomment-2408332827
> > This caused by the specifical meaning of _ and % in mysql, there might exist other symbosl same with these. I didn't find out good idea to solve these problem, seems we need to escape these characters, but this will introduce more problems. > > This is not just a problem in MySQL,the PG used in our project have The same problem, and it has been fixed and is currently in use online. > > Our project testers initially discovered this issue and recorded a bug for us to fix. But this change is not elegant enough. We have to call this method every time. It would be great if it could be made into AOP or annotations My concern is we escape the search condition will cause more bugs, I would prefer the user use the escaped keyword in front-end. On the other hand, we cannot escape all parameters, this bug only affect `fuzzy` query, if we escape all parameters will cause other method have bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
