SbloodyS commented on code in PR #16681:
URL:
https://github.com/apache/dolphinscheduler/pull/16681#discussion_r1796708585
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.xml:
##########
@@ -200,10 +200,14 @@
project_code as projectCode
,count(*) as count
from t_ds_workflow_definition
- where project_code in
- <foreach collection="projectCodes" index="index" item="i" open="("
separator="," close=")">
- #{i}
- </foreach>
+ <where>
Review Comment:
> However, if someone uses this method in the future, there will be error.
We shouldn't do double check at every entrance, which is unreasonable.
Avoiding similar problems should be ensured by ut and e2e tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
