ruanwenjun commented on code in PR #16593:
URL:
https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1746719910
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -1,4 +1,4 @@
-#
+ #
Review Comment:
This change is not changed.
##########
dolphinscheduler-bom/pom.xml:
##########
@@ -927,10 +927,6 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-api</artifactId>
- </exclusion>
Review Comment:
Why remove this?
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java:
##########
@@ -117,7 +117,7 @@ public void setHostAndPortByAddress(String address) {
}
this.host = String.join(Constants.COMMA, hosts);
- this.port = Integer.parseInt(portString);
+ this.port = (Integer) Integer.parseInt(portString);
Review Comment:
This change is not needed
##########
dolphinscheduler-api/pom.xml:
##########
@@ -121,10 +121,6 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-tomcat</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-to-slf4j</artifactId>
- </exclusion>
Review Comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
