SbloodyS commented on code in PR #16288:
URL:
https://github.com/apache/dolphinscheduler/pull/16288#discussion_r1671713461
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -407,11 +413,65 @@ protected Map<String, Object> createDagDefine(User
loginUser,
processDefinition.getProjectCode(),
processDefinition.getCode(), insertVersion);
}
+ saveProcessLineage(taskDefinitionLogs,
processDefinition.getProjectCode(), processDefinition.getCode(),
+ insertVersion);
+
putMsg(result, Status.SUCCESS);
result.put(Constants.DATA_LIST, processDefinition);
return result;
}
+ @Override
+ public void saveProcessLineage(List<TaskDefinitionLog>
taskDefinitionLogList,
+ long projectCode,
+ long processDefinitionCode,
+ int processDefinitionVersion) {
+ List<ProcessLineage> processLineageList =
+ generateProcessLineageList(taskDefinitionLogList,
processDefinitionCode, processDefinitionVersion);
+ if (!processLineageList.isEmpty()) {
+ int insertProcessLineageResult =
processLineageService.updateProcessLineage(processLineageList);
+ if (insertProcessLineageResult <= 0) {
+ log.error(
+ "Save process lineage error, projectCode: {},
processDefinitionCode: {}, processDefinitionVersion: {}",
+ projectCode, processDefinitionCode,
processDefinitionVersion);
+ throw new
ServiceException(Status.CREATE_PROCESS_LINEAGE_ERROR);
+ } else {
+ log.info(
+ "Save process lineage complete, projectCode: {},
processDefinitionCode: {}, processDefinitionVersion: {}",
+ projectCode, processDefinitionCode,
processDefinitionVersion);
+ }
+ }
+
+ }
+
+ private List<ProcessLineage>
generateProcessLineageList(List<TaskDefinitionLog> taskDefinitionLogList,
+ long
processDefinitionCode,
+ int
processDefinitionVersion) {
+ List<ProcessLineage> processLineageList = new ArrayList<>();
+ for (TaskDefinitionLog taskDefinitionLog : taskDefinitionLogList) {
+
+ if
(TaskTypeUtils.isDependentTask(taskDefinitionLog.getTaskType())) {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
