ruanwenjun commented on code in PR #16277:
URL:
https://github.com/apache/dolphinscheduler/pull/16277#discussion_r1666341714
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-zookeeper/src/main/java/org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperRegistryProperties.java:
##########
@@ -100,11 +101,17 @@ public static final class ZookeeperProperties {
private String namespace = "dolphinscheduler";
private String connectString;
private RetryPolicy retryPolicy = new RetryPolicy();
- private String digest;
+ private Authorization authorization = new Authorization();
Review Comment:
Use Map is enough, then we don't need know the key in code.
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-zookeeper/src/main/java/org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperRegistryProperties.java:
##########
@@ -100,11 +101,17 @@ public static final class ZookeeperProperties {
private String namespace = "dolphinscheduler";
private String connectString;
private RetryPolicy retryPolicy = new RetryPolicy();
- private String digest;
+ private Authorization authorization = new Authorization();
Review Comment:
```suggestion
private Map<String, String> authorization = new HashMap<>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
