SbloodyS commented on code in PR #15912:
URL:
https://github.com/apache/dolphinscheduler/pull/15912#discussion_r1582004990
##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx:
##########
@@ -505,16 +504,13 @@ export default defineComponent({
label={t('project.workflow.parallelism')}
path='expectedParallelismNumber'
>
- <NCheckbox v-model:checked={this.parallelismRef}>
- {t('project.workflow.custom_parallelism')}
- </NCheckbox>
- <NInput
- allowInput={this.trim}
- disabled={!this.parallelismRef}
+ <NInputNumber
placeholder={t(
'project.workflow.please_enter_parallelism'
)}
v-model:value={this.startForm.expectedParallelismNumber}
+ max='100'
+ min='1'
Review Comment:
> You can try to set `task-execute-threads-full-policy` to be REJECT, then
the worker will only receive 100 tasks.
>
>
https://github.com/apache/dolphinscheduler/blob/d1135eabc7df9358fd210e423785d1067af64698/dolphinscheduler-worker/src/main/resources/application.yaml#L66-L66
>
> BTW, I agree with @Gallardot if we want to set a maximal restriction, it's
better to make this value to be configurable.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]