EricGao888 commented on code in PR #15922:
URL:
https://github.com/apache/dolphinscheduler/pull/15922#discussion_r1580525316
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -794,6 +794,97 @@ alert:
labels: {}
# -- serviceMonitor.annotations ServiceMonitor annotations
annotations: {}
+ configmap:
Review Comment:
I don't think we need to put everything into values. In the future, probably
we will have separated configmaps for api server, master server and worker
server. Why not put them directly in `configmap-dolphinscheduler-alert.yam`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
