rickchengx commented on code in PR #15865:
URL:
https://github.com/apache/dolphinscheduler/pull/15865#discussion_r1569804320
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/test/java/org/apache/dolphinscheduler/plugin/task/api/utils/ParameterUtilsTest.java:
##########
@@ -113,4 +113,15 @@ public void testHandleEscapes() throws Exception {
Assertions.assertEquals("test Parameter",
ParameterUtils.handleEscapes("test Parameter"));
Assertions.assertEquals("////%test////%Parameter",
ParameterUtils.handleEscapes("%test%Parameter"));
}
+
+ @Test
+ public void testProcessSqlQuestionMark() {
+ String querySql = "select id, concat('?', name) from test";
+ String expected = "select id, concat('@@QUESTION_UNIQUE_MARK@@', name)
from test";
Review Comment:
maybe this unique mark could be a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
