SbloodyS commented on code in PR #15619:
URL:
https://github.com/apache/dolphinscheduler/pull/15619#discussion_r1500290123
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java:
##########
@@ -75,4 +77,15 @@ public static <T> PageInfo<T> of(IPage<T> iPage) {
public static <T> PageInfo<T> of(Integer currentPage, Integer pageSize) {
return new PageInfo<>(currentPage, pageSize);
}
+
+ public Integer getTotalPage() {
Review Comment:
> @DaZuiZui The original code is from a previously deleted section
[#15181](https://github.com/apache/dolphinscheduler/pull/15181/files#diff-c367978011e1fa572823ec7cec246f9a21ad88699ef9c764ee39e9c96d23914b).
But your suggestions are better, there is no reason not to optimize, you are
welcome to create a PR❤️.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
