This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push: new 3cb9c9dd Sort members new 2a87912a Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-bcel.git 3cb9c9dd is described below commit 3cb9c9dd28a8ad85e948df9df236c1d71670add4 Author: Gary David Gregory (Code signing key) <ggreg...@apache.org> AuthorDate: Sat Apr 8 12:03:34 2023 -0400 Sort members --- .../apache/bcel/classfile/SignatureTestCase.java | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/test/java/org/apache/bcel/classfile/SignatureTestCase.java b/src/test/java/org/apache/bcel/classfile/SignatureTestCase.java index 43c835ff..9726e506 100644 --- a/src/test/java/org/apache/bcel/classfile/SignatureTestCase.java +++ b/src/test/java/org/apache/bcel/classfile/SignatureTestCase.java @@ -33,6 +33,22 @@ import static org.junit.jupiter.api.Assertions.assertThrowsExactly; */ public class SignatureTestCase extends AbstractTestCase { + @Test + public void testBadSignatures() throws Exception { + assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<")); + assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<>")); + } + + @Test + public void testMap() throws Exception { + final JavaClass jc = Repository.lookupClass(Map.class); + final Signature classSignature = (Signature) findAttribute("Signature", jc.getAttributes()); + final String translatedSignature = Signature.translate(classSignature.getSignature()); + assertEquals("<K, V>java.lang.Object", translatedSignature); + testMethod(jc, "(java.lang.Object)V", Map.class, "get", Object.class); + testMethod(jc, "(K, V)V", Map.class, "put", Object.class, Object.class); + } + void testMethod(final JavaClass jc, final String expected, final Class<?> clazz, final String methodName, final Class<?>... paramTypes) throws Exception { final Method method = jc.getMethod(clazz.getMethod(methodName, paramTypes)); final String methodSignature = Optional.ofNullable(method.getGenericSignature()).orElse(method.getSignature()); @@ -50,22 +66,6 @@ public class SignatureTestCase extends AbstractTestCase { } - @Test - public void testMap() throws Exception { - final JavaClass jc = Repository.lookupClass(Map.class); - final Signature classSignature = (Signature) findAttribute("Signature", jc.getAttributes()); - final String translatedSignature = Signature.translate(classSignature.getSignature()); - assertEquals("<K, V>java.lang.Object", translatedSignature); - testMethod(jc, "(java.lang.Object)V", Map.class, "get", Object.class); - testMethod(jc, "(K, V)V", Map.class, "put", Object.class, Object.class); - } - - @Test - public void testBadSignatures() throws Exception { - assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<")); - assertThrowsExactly(IllegalArgumentException.class, () -> Signature.translate("<>")); - } - @Test public void testType() throws Exception { assertEquals("(I)I", Type.getSignature(Math.class.getMethod("abs", int.class)));