[commons-bcel] 01/02: Use Arrays.copyOf()

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit ff9a4bba813b384ef0644552b9dc3263ecbc1ca0
Author: Gary David Gregory (Code signing key) <ggreg...@apache.org>
AuthorDate: Wed Dec 28 11:03:58 2022 -0500

    Use Arrays.copyOf()
---
 src/main/java/org/apache/bcel/generic/ConstantPoolGen.java | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java 
b/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
index 68feb64f..0dc45781 100644
--- a/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
+++ b/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
@@ -105,9 +105,8 @@ public class ConstantPoolGen {
         final StringBuilder sb = new StringBuilder(DEFAULT_BUFFER_SIZE);
 
         size = Math.min(Math.max(DEFAULT_BUFFER_SIZE, cs.length + 64), 
Const.MAX_CP_ENTRIES + 1);
-        constants = new Constant[size];
+        constants = Arrays.copyOf(cs, size);
 
-        System.arraycopy(cs, 0, constants, 0, cs.length);
         if (cs.length > 0) {
             index = cs.length;
         }
@@ -538,12 +537,12 @@ public class ConstantPoolGen {
         }
 
         if (index + 3 >= size) {
-            final Constant[] cs = constants;
+            final Constant[] tmp = constants;
             size *= 2;
             // the constant array shall not exceed the size of the constant 
pool
             size = Math.min(size, Const.MAX_CP_ENTRIES + 1);
             constants = new Constant[size];
-            System.arraycopy(cs, 0, constants, 0, index);
+            System.arraycopy(tmp, 0, constants, 0, index);
         }
     }