This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new dc3a5733 Lookup key in map only once
dc3a5733 is described below

commit dc3a5733d26824a95acb219bc1fe16227688e4ad
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Nov 30 10:43:19 2022 -0500

    Lookup key in map only once
---
 src/main/java/org/apache/commons/beanutils2/LazyDynaMap.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/LazyDynaMap.java 
b/src/main/java/org/apache/commons/beanutils2/LazyDynaMap.java
index 4e1521af..b211b12f 100644
--- a/src/main/java/org/apache/commons/beanutils2/LazyDynaMap.java
+++ b/src/main/java/org/apache/commons/beanutils2/LazyDynaMap.java
@@ -218,14 +218,14 @@ public class LazyDynaMap extends LazyDynaBean implements 
MutableDynaClass {
             throw new IllegalArgumentException("Property name is missing.");
         }
 
+        final Object value = values.get(name);
+
         // If it doesn't exist and returnNull is false
         // create a new DynaProperty
-        if (!values.containsKey(name) && isReturnNull()) {
+        if (value == null && isReturnNull()) {
             return null;
         }
 
-        final Object value = values.get(name);
-
         if (value == null) {
             return new DynaProperty(name);
         }

Reply via email to