This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git

commit b7e0d11bcd42f1f0d59985c6f0c0b716959aef74
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Nov 30 10:14:30 2022 -0500

    Lookup key in map only once
---
 .../compress/harmony/unpack200/SegmentConstantPoolArrayCache.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java
 
b/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java
index fb5d3cd1..264a994a 100644
--- 
a/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java
+++ 
b/src/main/java/org/apache/commons/compress/harmony/unpack200/SegmentConstantPoolArrayCache.java
@@ -132,10 +132,8 @@ public class SegmentConstantPoolArrayCache {
          * @return List of indexes containing that key in the array.
          */
         public List<Integer> indexesForKey(final String key) {
-            if (!primaryTable.containsKey(key)) {
-                return Collections.EMPTY_LIST;
-            }
-            return primaryTable.get(key);
+            final List<Integer> list = primaryTable.get(key);
+            return list != null ? list : Collections.emptyList();
         }
 
         /**

Reply via email to