This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git
The following commit(s) were added to refs/heads/master by this push:
new 5d10f558 Avoid use C-in the array. (#244)
5d10f558 is described below
commit 5d10f5589533d19f70d9948612eead9915df79eb
Author: Arturo Bernal <arturobern...@gmail.com>
AuthorDate: Sat Nov 26 00:42:52 2022 +0100
Avoid use C-in the array. (#244)
---
.../configuration2/TestDynamicCombinedConfiguration.java | 14 +++++++-------
.../commons/configuration2/TestXMLConfiguration.java | 2 +-
.../beanutils/TestConfigurationDynaBean.java | 4 ++--
...TestReloadingCombinedConfigurationBuilderFileBased.java | 4 ++--
.../org/apache/commons/configuration2/test/HsqlDB.java | 2 +-
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git
a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
index 8a1a4aa0..7d3130f8 100644
---
a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
+++
b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
@@ -237,8 +237,8 @@ public class TestDynamicCombinedConfiguration {
final CombinedConfiguration config = builder.getConfiguration();
assertEquals("50", config.getString("rowsPerPage"));
- final Thread testThreads[] = new Thread[THREAD_COUNT];
- final int failures[] = new int[THREAD_COUNT];
+ final Thread[] testThreads = new Thread[THREAD_COUNT];
+ final int[] failures = new int[THREAD_COUNT];
for (int i = 0; i < testThreads.length; ++i) {
testThreads[i] = new ReloadThread(builder, failures, i,
LOOP_COUNT, false, null, "50");
@@ -262,8 +262,8 @@ public class TestDynamicCombinedConfiguration {
assertEquals("50", config.getString("rowsPerPage"));
- final Thread testThreads[] = new Thread[THREAD_COUNT];
- final int failures[] = new int[THREAD_COUNT];
+ final Thread[] testThreads = new Thread[THREAD_COUNT];
+ final int[] failures = new int[THREAD_COUNT];
System.setProperty("Id", "2002");
assertEquals("25", config.getString("rowsPerPage"));
for (int i = 0; i < testThreads.length; ++i) {
@@ -299,7 +299,7 @@ public class TestDynamicCombinedConfiguration {
CombinedConfiguration config = builder.getConfiguration();
assertEquals("ID0001",
config.getString("Product/FIIndex/FI[@id='123456781']"));
- final ReaderThread testThreads[] = new ReaderThread[threadCount];
+ final ReaderThread[] testThreads = new ReaderThread[threadCount];
for (int i = 0; i < testThreads.length; ++i) {
testThreads[i] = new ReaderThread(builder);
testThreads[i].start();
@@ -339,8 +339,8 @@ public class TestDynamicCombinedConfiguration {
assertEquals("50", config.getString("rowsPerPage"));
- final Thread testThreads[] = new Thread[THREAD_COUNT];
- final int failures[] = new int[THREAD_COUNT];
+ final Thread[] testThreads = new Thread[THREAD_COUNT];
+ final int[] failures = new int[THREAD_COUNT];
final String[] ids = {null, "2002", "3001", "3002", "3003"};
final String[] expected = {"50", "25", "15", "25", "50"};
for (int i = 0; i < testThreads.length; ++i) {
diff --git
a/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
b/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
index 840055c6..d10ac971 100644
--- a/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/TestXMLConfiguration.java
@@ -589,7 +589,7 @@ public class TestXMLConfiguration {
XMLConfiguration config = builder.getConfiguration();
assertNotNull(config.getProperty("test.short"));
- final Thread testThreads[] = new Thread[THREAD_COUNT];
+ final Thread[] testThreads = new Thread[THREAD_COUNT];
for (int i = 0; i < testThreads.length; ++i) {
testThreads[i] = new ReloadThread(builder);
testThreads[i].start();
diff --git
a/src/test/java/org/apache/commons/configuration2/beanutils/TestConfigurationDynaBean.java
b/src/test/java/org/apache/commons/configuration2/beanutils/TestConfigurationDynaBean.java
index 307f6025..eb5c818c 100644
---
a/src/test/java/org/apache/commons/configuration2/beanutils/TestConfigurationDynaBean.java
+++
b/src/test/java/org/apache/commons/configuration2/beanutils/TestConfigurationDynaBean.java
@@ -192,9 +192,9 @@ public class TestConfigurationDynaBean {
*/
@Test
public void testGetDescriptors() {
- final DynaProperty pd[] = bean.getDynaClass().getDynaProperties();
+ final DynaProperty[] pd = bean.getDynaClass().getDynaProperties();
assertNotNull(pd);
- final int count[] = new int[properties.length];
+ final int[] count = new int[properties.length];
for (final DynaProperty element : pd) {
final String name = element.getName();
for (int j = 0; j < properties.length; j++) {
diff --git
a/src/test/java/org/apache/commons/configuration2/builder/combined/TestReloadingCombinedConfigurationBuilderFileBased.java
b/src/test/java/org/apache/commons/configuration2/builder/combined/TestReloadingCombinedConfigurationBuilderFileBased.java
index 7e723c99..ca844174 100644
---
a/src/test/java/org/apache/commons/configuration2/builder/combined/TestReloadingCombinedConfigurationBuilderFileBased.java
+++
b/src/test/java/org/apache/commons/configuration2/builder/combined/TestReloadingCombinedConfigurationBuilderFileBased.java
@@ -223,8 +223,8 @@ public class
TestReloadingCombinedConfigurationBuilderFileBased {
assertEquals("100",
builder.getConfiguration().getString("/property[@name='config']/@value"));
- final Thread testThreads[] = new Thread[threadCount];
- final int failures[] = new int[threadCount];
+ final Thread[] testThreads = new Thread[threadCount];
+ final int[] failures = new int[threadCount];
for (int i = 0; i < testThreads.length; ++i) {
testThreads[i] = new ReloadThread(builder, failures, i, loopCount);
diff --git a/src/test/java/org/apache/commons/configuration2/test/HsqlDB.java
b/src/test/java/org/apache/commons/configuration2/test/HsqlDB.java
index e81b318f..0ec2f0e9 100644
--- a/src/test/java/org/apache/commons/configuration2/test/HsqlDB.java
+++ b/src/test/java/org/apache/commons/configuration2/test/HsqlDB.java
@@ -61,7 +61,7 @@ public class HsqlDB {
private String getFileContents(final String fileName) throws Exception {
try (FileReader fr = new FileReader(fileName)) {
- final char fileBuf[] = new char[1024];
+ final char[] fileBuf = new char[1024];
final StringBuilder sb = new StringBuilder(1000);
int res = -1;
