[commons-bcel] branch master updated: Use final

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new bb988482 Use final
bb988482 is described below

commit bb988482b01028a015e3c2169d64975bb853502d
Author: Gary David Gregory (Code signing key) <ggreg...@apache.org>
AuthorDate: Wed Nov 9 11:05:30 2022 -0500

    Use final
---
 .../java/org/apache/bcel/generic/ConstantPoolGen.java    | 16 ++++++++--------
 src/main/java/org/apache/bcel/generic/MethodGen.java     |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java 
b/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
index e47ca57b..cf7ff315 100644
--- a/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
+++ b/src/main/java/org/apache/bcel/generic/ConstantPoolGen.java
@@ -358,8 +358,8 @@ public class ConstantPoolGen {
             return cpRet; // Already in CP
         }
         adjustSize();
-        int classIndex = addClass(className);
-        int nameAndTypeIndex = addNameAndType(fieldName, signature);
+        final int classIndex = addClass(className);
+        final int nameAndTypeIndex = addNameAndType(fieldName, signature);
         final int ret = index;
         constants[index++] = new ConstantFieldref(classIndex, 
nameAndTypeIndex);
         return computeIfAbsent(cpTable, className + FIELDREF_DELIM + fieldName 
+ FIELDREF_DELIM + signature, ret);
@@ -417,8 +417,8 @@ public class ConstantPoolGen {
             return cpRet; // Already in CP
         }
         adjustSize();
-        int classIndex = addClass(className);
-        int nameAndTypeIndex = addNameAndType(methodName, signature);
+        final int classIndex = addClass(className);
+        final int nameAndTypeIndex = addNameAndType(methodName, signature);
         final int ret = index;
         constants[index++] = new ConstantInterfaceMethodref(classIndex, 
nameAndTypeIndex);
         return computeIfAbsent(cpTable, className + IMETHODREF_DELIM + 
methodName + IMETHODREF_DELIM + signature, ret);
@@ -459,8 +459,8 @@ public class ConstantPoolGen {
             return cpRet; // Already in CP
         }
         adjustSize();
-        int nameAndTypeIndex = addNameAndType(methodName, signature);
-        int classIndex = addClass(className);
+        final int nameAndTypeIndex = addNameAndType(methodName, signature);
+        final int classIndex = addClass(className);
         final int ret = index;
         constants[index++] = new ConstantMethodref(classIndex, 
nameAndTypeIndex);
         return computeIfAbsent(cpTable, className + METHODREF_DELIM + 
methodName + METHODREF_DELIM + signature, ret);
@@ -479,8 +479,8 @@ public class ConstantPoolGen {
             return ret; // Already in CP
         }
         adjustSize();
-        int nameIndex = addUtf8(name);
-        int signatureIndex = addUtf8(signature);
+        final int nameIndex = addUtf8(name);
+        final int signatureIndex = addUtf8(signature);
         ret = index;
         constants[index++] = new ConstantNameAndType(nameIndex, 
signatureIndex);
         return computeIfAbsent(natTable, name + NAT_DELIM + signature, ret);
diff --git a/src/main/java/org/apache/bcel/generic/MethodGen.java 
b/src/main/java/org/apache/bcel/generic/MethodGen.java
index a97bc9d7..afe7dfa0 100644
--- a/src/main/java/org/apache/bcel/generic/MethodGen.java
+++ b/src/main/java/org/apache/bcel/generic/MethodGen.java
@@ -800,7 +800,7 @@ public class MethodGen extends FieldGenOrMethodGen {
         /*
          * Also updates positions of instructions, i.e., their indices
          */
-        byte[] byteCode = il != null ? il.getByteCode() : null;
+        final byte[] byteCode = il != null ? il.getByteCode() : null;
         LineNumberTable lnt = null;
         LocalVariableTable lvt = null;
         /*