This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-csv.git
commit ed43bba32ca849b063b0670fa134e5151bd4b479 Author: Gary Gregory <[email protected]> AuthorDate: Tue Oct 25 21:38:18 2022 -0400 Use final and lambda shorthand --- src/main/java/org/apache/commons/csv/CSVFormat.java | 2 +- src/test/java/org/apache/commons/csv/CSVParserTest.java | 3 ++- src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/commons/csv/CSVFormat.java b/src/main/java/org/apache/commons/csv/CSVFormat.java index 1626a6a9..81b6f193 100644 --- a/src/main/java/org/apache/commons/csv/CSVFormat.java +++ b/src/main/java/org/apache/commons/csv/CSVFormat.java @@ -2305,7 +2305,7 @@ public final class CSVFormat implements Serializable { if (headers != null && duplicateHeaderMode != DuplicateHeaderMode.ALLOW_ALL) { final Set<String> dupCheckSet = new HashSet<>(headers.length); final boolean emptyDuplicatesAllowed = duplicateHeaderMode == DuplicateHeaderMode.ALLOW_EMPTY; - for (String header : headers) { + for (final String header : headers) { final boolean blank = isBlank(header); // Sanitise all empty headers to the empty string "" when checking duplicates final boolean containsHeader = !dupCheckSet.add(blank ? "" : header); diff --git a/src/test/java/org/apache/commons/csv/CSVParserTest.java b/src/test/java/org/apache/commons/csv/CSVParserTest.java index ae4769f0..e01f0233 100644 --- a/src/test/java/org/apache/commons/csv/CSVParserTest.java +++ b/src/test/java/org/apache/commons/csv/CSVParserTest.java @@ -53,6 +53,7 @@ import java.util.stream.Collectors; import org.apache.commons.io.input.BOMInputStream; import org.apache.commons.io.input.BrokenInputStream; +import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; @@ -113,7 +114,7 @@ public class CSVParserTest { } private void parseFully(final CSVParser parser) { - parser.forEach(record -> assertNotNull(record)); + parser.forEach(Assertions::assertNotNull); } @Test diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java index eeb4d912..37209e7a 100644 --- a/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java +++ b/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java @@ -31,8 +31,8 @@ import org.junit.jupiter.api.Test; public class JiraCsv288Test { - private void print(final CSVRecord csvRecord, CSVPrinter csvPrinter) throws IOException { - for (String value : csvRecord) { + private void print(final CSVRecord csvRecord, final CSVPrinter csvPrinter) throws IOException { + for (final String value : csvRecord) { csvPrinter.print(value); } }
