This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 3f86df701cb96b016472b7b6c647ef4b313507cd Author: Gary David Gregory (Code signing key) <ggreg...@apache.org> AuthorDate: Sun Oct 23 09:18:39 2022 -0400 Use camel case names --- src/main/java/org/apache/bcel/classfile/JavaClass.java | 6 +++--- src/main/java/org/apache/bcel/classfile/Utility.java | 6 +++--- src/main/java/org/apache/bcel/generic/InstructionList.java | 6 +++--- src/main/java/org/apache/bcel/generic/SWITCH.java | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/main/java/org/apache/bcel/classfile/JavaClass.java b/src/main/java/org/apache/bcel/classfile/JavaClass.java index 2b184c74..02b69235 100644 --- a/src/main/java/org/apache/bcel/classfile/JavaClass.java +++ b/src/main/java/org/apache/bcel/classfile/JavaClass.java @@ -145,16 +145,16 @@ public class JavaClass extends AccessFlags implements Cloneable, Node, Comparabl * @param fileName File name * @param major Major compiler version * @param minor Minor compiler version - * @param access_flags Access rights defined by bit flags + * @param accessFlags Access rights defined by bit flags * @param constantPool Array of constants * @param interfaces Implemented interfaces * @param fields Class fields * @param methods Class methods * @param attributes Class attributes */ - public JavaClass(final int classNameIndex, final int superclassNameIndex, final String fileName, final int major, final int minor, final int access_flags, + public JavaClass(final int classNameIndex, final int superclassNameIndex, final String fileName, final int major, final int minor, final int accessFlags, final ConstantPool constantPool, final int[] interfaces, final Field[] fields, final Method[] methods, final Attribute[] attributes) { - this(classNameIndex, superclassNameIndex, fileName, major, minor, access_flags, constantPool, interfaces, fields, methods, attributes, HEAP); + this(classNameIndex, superclassNameIndex, fileName, major, minor, accessFlags, constantPool, interfaces, fields, methods, attributes, HEAP); } /** diff --git a/src/main/java/org/apache/bcel/classfile/Utility.java b/src/main/java/org/apache/bcel/classfile/Utility.java index 95b699a3..53beeba5 100644 --- a/src/main/java/org/apache/bcel/classfile/Utility.java +++ b/src/main/java/org/apache/bcel/classfile/Utility.java @@ -732,15 +732,15 @@ public abstract class Utility { * * @param str string to format * @param length length of desired string - * @param left_justify format left or right + * @param leftJustify format left or right * @param fill fill character * @return formatted string */ - public static String fillup(final String str, final int length, final boolean left_justify, final char fill) { + public static String fillup(final String str, final int length, final boolean leftJustify, final char fill) { final int len = length - str.length(); final char[] buf = new char[Math.max(len, 0)]; Arrays.fill(buf, fill); - if (left_justify) { + if (leftJustify) { return str + new String(buf); } return new String(buf) + str; diff --git a/src/main/java/org/apache/bcel/generic/InstructionList.java b/src/main/java/org/apache/bcel/generic/InstructionList.java index 125b0ea3..4735f095 100644 --- a/src/main/java/org/apache/bcel/generic/InstructionList.java +++ b/src/main/java/org/apache/bcel/generic/InstructionList.java @@ -923,7 +923,7 @@ public class InstructionList implements Iterable<InstructionHandle> { } /** - * Redirect all references from old_target to new_target, i.e., update targets of branch instructions. + * Redirect all references from oldTarget to newTarget, i.e., update targets of branch instructions. * * @param oldTarget the old target instruction handle * @param newTarget the new target instruction handle @@ -950,7 +950,7 @@ public class InstructionList implements Iterable<InstructionHandle> { } /** - * Redirect all references of exception handlers from old_target to new_target. + * Redirect all references of exception handlers from oldTarget to newTarget. * * @param exceptions array of exception handlers * @param oldTarget the old target instruction handle @@ -972,7 +972,7 @@ public class InstructionList implements Iterable<InstructionHandle> { } /** - * Redirect all references of local variables from old_target to new_target. + * Redirect all references of local variables from oldTarget to newTarget. * * @param lg array of local variables * @param oldTarget the old target instruction handle diff --git a/src/main/java/org/apache/bcel/generic/SWITCH.java b/src/main/java/org/apache/bcel/generic/SWITCH.java index 357f268c..caa79f50 100644 --- a/src/main/java/org/apache/bcel/generic/SWITCH.java +++ b/src/main/java/org/apache/bcel/generic/SWITCH.java @@ -33,7 +33,7 @@ public final class SWITCH implements CompoundInstruction { /** * Template for switch() constructs. If the match array can be sorted in ascending order with gaps no larger than - * max_gap between the numbers, a TABLESWITCH instruction is generated, and a LOOKUPSWITCH otherwise. The former may be + * maxGap between the numbers, a TABLESWITCH instruction is generated, and a LOOKUPSWITCH otherwise. The former may be * more efficient, but needs more space. * * Note, that the key array always will be sorted, though we leave the original arrays unaltered. @@ -94,7 +94,7 @@ public final class SWITCH implements CompoundInstruction { } /** - * @return match is sorted in ascending order with no gap bigger than max_gap? + * @return match is sorted in ascending order with no gap bigger than maxGap? */ private boolean matchIsOrdered(final int maxGap) { for (int i = 1; i < matchLength; i++) {