This is an automated email from the ASF dual-hosted git repository. aherbert pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 9632942c5059448da1a7106531ec65ab281e39e8 Author: aherbert <aherb...@apache.org> AuthorDate: Mon Oct 3 12:01:50 2022 +0100 Use LogNormalSampler from commons RNG --- .../commons/statistics/distribution/LogNormalDistribution.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogNormalDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogNormalDistribution.java index 8e667b9..686aa03 100644 --- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogNormalDistribution.java +++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/LogNormalDistribution.java @@ -21,6 +21,7 @@ import org.apache.commons.numbers.gamma.ErfDifference; import org.apache.commons.numbers.gamma.Erfc; import org.apache.commons.numbers.gamma.InverseErfc; import org.apache.commons.rng.UniformRandomProvider; +import org.apache.commons.rng.sampling.distribution.LogNormalSampler; import org.apache.commons.rng.sampling.distribution.ZigguratSampler; /** @@ -261,8 +262,6 @@ public final class LogNormalDistribution extends AbstractContinuousDistribution public ContinuousDistribution.Sampler createSampler(final UniformRandomProvider rng) { // Log normal distribution sampler. final ZigguratSampler.NormalizedGaussian gaussian = ZigguratSampler.NormalizedGaussian.of(rng); - // TODO: Replace with LogNormalSampler in Commons RNG when - // the version supporting negative mu has been released. - return () -> Math.exp(mu + sigma * gaussian.sample()); + return LogNormalSampler.of(gaussian, mu, sigma)::sample; } }