This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 215d07adfab2b4f7336ba90c3b3f1ceb5039ef9a Author: Gary David Gregory (Code signing key) <[email protected]> AuthorDate: Sun Oct 2 13:36:22 2022 -0400 Use isEmpty() APIs --- src/main/java/org/apache/bcel/util/BCELifier.java | 2 +- src/main/java/org/apache/bcel/util/JavaWrapper.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/bcel/util/BCELifier.java b/src/main/java/org/apache/bcel/util/BCELifier.java index 42aa2375..1ef8093e 100644 --- a/src/main/java/org/apache/bcel/util/BCELifier.java +++ b/src/main/java/org/apache/bcel/util/BCELifier.java @@ -240,7 +240,7 @@ public class BCELifier extends org.apache.bcel.classfile.EmptyVisitor { printWriter.println(" private ClassGen _cg;"); printWriter.println(); printWriter.println(" public " + className + "Creator() {"); - printWriter.println(" _cg = new ClassGen(\"" + ("".equals(packageName) ? className : packageName + "." + className) + "\", \"" + superName + printWriter.println(" _cg = new ClassGen(\"" + (packageName.isEmpty() ? className : packageName + "." + className) + "\", \"" + superName + "\", " + "\"" + clazz.getSourceFileName() + "\", " + printFlags(clazz.getAccessFlags(), FLAGS.CLASS) + ", " + "new String[] { " + inter + " });"); printWriter.println(" _cg.setMajor(" + clazz.getMajor() + ");"); printWriter.println(" _cg.setMinor(" + clazz.getMinor() + ");"); diff --git a/src/main/java/org/apache/bcel/util/JavaWrapper.java b/src/main/java/org/apache/bcel/util/JavaWrapper.java index dc6cbd16..1a57abb8 100644 --- a/src/main/java/org/apache/bcel/util/JavaWrapper.java +++ b/src/main/java/org/apache/bcel/util/JavaWrapper.java @@ -20,6 +20,8 @@ package org.apache.bcel.util; import java.lang.reflect.Method; import java.lang.reflect.Modifier; +import org.apache.commons.lang3.StringUtils; + /** * Java interpreter replacement, i.e., wrapper that uses its own ClassLoader to modify/generate classes as they're * requested. You can take this as a template for your own applications. @@ -44,7 +46,7 @@ public class JavaWrapper { private static java.lang.ClassLoader getClassLoader() { final String s = System.getProperty("bcel.classloader"); - if (s == null || "".equals(s)) { + if (StringUtils.isEmpty(s)) { throw new IllegalStateException("The property 'bcel.classloader' must be defined"); } try {
