This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 7cb81aa26f1afcfa7b2babd7b3e7ff9a4e8b5733
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Aug 26 14:29:24 2022 -0400
PMD: Remove extra parens
---
src/main/java/org/apache/commons/lang3/ArrayUtils.java | 4 ++--
src/main/java/org/apache/commons/lang3/StringUtils.java | 8 ++++----
src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java | 2 +-
src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java | 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
index fb90edc6d..eef29dc7b 100644
--- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
@@ -2478,7 +2478,7 @@ public class ArrayUtils {
final boolean searchNaN = Double.isNaN(valueToFind);
for (int i = startIndex; i < array.length; i++) {
final double element = array[i];
- if (valueToFind == element || (searchNaN &&
Double.isNaN(element))) {
+ if (valueToFind == element || searchNaN && Double.isNaN(element)) {
return i;
}
}
@@ -2562,7 +2562,7 @@ public class ArrayUtils {
final boolean searchNaN = Float.isNaN(valueToFind);
for (int i = startIndex; i < array.length; i++) {
final float element = array[i];
- if (valueToFind == element || (searchNaN && Float.isNaN(element)))
{
+ if (valueToFind == element || searchNaN && Float.isNaN(element)) {
return i;
}
}
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java
b/src/main/java/org/apache/commons/lang3/StringUtils.java
index b242191a3..eddebf700 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -2756,7 +2756,7 @@ public class StringUtils {
final char ch = cs.charAt(i);
for (int j = 0; j < searchLen; j++) {
if (searchChars[j] == ch) {
- if ((i >= csLast) || (j >= searchLast) ||
!Character.isHighSurrogate(ch)) {
+ if (i >= csLast || j >= searchLast ||
!Character.isHighSurrogate(ch)) {
return i;
}
// ch is a supplementary character
@@ -2889,7 +2889,7 @@ public class StringUtils {
final char ch = cs.charAt(i);
for (int j = 0; j < searchLen; j++) {
if (searchChars[j] == ch) {
- if ((i >= csLast) || (j >= searchLast) ||
!Character.isHighSurrogate(ch)) {
+ if (i >= csLast || j >= searchLast ||
!Character.isHighSurrogate(ch)) {
continue outer;
}
if (searchChars[j + 1] == cs.charAt(i + 1)) {
@@ -5486,7 +5486,7 @@ public class StringUtils {
whitespacesCount++;
} else {
startWhitespaces = false;
- newChars[count++] = (actualChar == 160 ? 32 : actualChar);
+ newChars[count++] = actualChar == 160 ? 32 : actualChar;
whitespacesCount = 0;
}
}
@@ -6636,7 +6636,7 @@ public class StringUtils {
}
}
- if (isEmpty(text) || ArrayUtils.isEmpty(searchList) ||
ArrayUtils.isEmpty(replacementList) || (ArrayUtils.isNotEmpty(searchList) &&
timeToLive == -1)) {
+ if (isEmpty(text) || ArrayUtils.isEmpty(searchList) ||
ArrayUtils.isEmpty(replacementList) || ArrayUtils.isNotEmpty(searchList) &&
timeToLive == -1) {
return text;
}
diff --git a/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
b/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
index 5e1ba2ce4..ce904f562 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java
@@ -993,7 +993,7 @@ public class MethodUtils {
final Class<?> acls;
if (interfaceIndex >= allInterfaces.size()) {
acls = allSuperclasses.get(superClassIndex++);
- } else if ((superClassIndex >= allSuperclasses.size()) ||
!(superClassIndex < interfaceIndex)) {
+ } else if (superClassIndex >= allSuperclasses.size() ||
!(superClassIndex < interfaceIndex)) {
acls = allInterfaces.get(interfaceIndex++);
} else {
acls = allSuperclasses.get(superClassIndex++);
diff --git a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
index c8ead80a3..68de4ccab 100644
--- a/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
+++ b/src/main/java/org/apache/commons/lang3/reflect/TypeUtils.java
@@ -124,7 +124,7 @@ public class TypeUtils {
*/
@Override
public boolean equals(final Object obj) {
- return obj == this || obj instanceof ParameterizedType &&
TypeUtils.equals(this, ((ParameterizedType) obj));
+ return obj == this || obj instanceof ParameterizedType &&
TypeUtils.equals(this, (ParameterizedType) obj);
}
/**
@@ -566,8 +566,8 @@ public class TypeUtils {
parameterizedType.getActualTypeArguments().length);
int[] indexesToRemove = {};
for (int i = 0; i < filteredArgumentTypes.length; i++) {
- if ((filteredArgumentTypes[i] instanceof TypeVariable<?>) &&
containsVariableTypeSameParametrizedTypeBound(
- ((TypeVariable<?>) filteredArgumentTypes[i]),
parameterizedType)) {
+ if (filteredArgumentTypes[i] instanceof TypeVariable<?> &&
containsVariableTypeSameParametrizedTypeBound(
+ (TypeVariable<?>) filteredArgumentTypes[i],
parameterizedType)) {
indexesToRemove = ArrayUtils.add(indexesToRemove, i);
}
}
