This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-configuration.git
The following commit(s) were added to refs/heads/master by this push: new 933b92e3 Use forEach() 933b92e3 is described below commit 933b92e37d6eccdbc4ad2ef20ce8afce6d7e5db8 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Tue Jul 19 16:58:07 2022 -0400 Use forEach() --- .../configuration2/plist/XMLPropertyListConfiguration.java | 4 +--- .../spring/ConfigurationPropertiesFactoryBean.java | 10 +++------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java b/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java index 2beb0f26..9703c775 100644 --- a/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java +++ b/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java @@ -669,9 +669,7 @@ public class XMLPropertyListConfiguration extends BaseHierarchicalConfiguration */ public ImmutableNode createNode() { final ImmutableNode.Builder nodeBuilder = new ImmutableNode.Builder(childBuilders.size()); - for (final PListNodeBuilder child : childBuilders) { - nodeBuilder.addChild(child.createNode()); - } + childBuilders.forEach(child -> nodeBuilder.addChild(child.createNode())); return nodeBuilder.name(name).value(getNodeValue()).create(); } diff --git a/src/main/java/org/apache/commons/configuration2/spring/ConfigurationPropertiesFactoryBean.java b/src/main/java/org/apache/commons/configuration2/spring/ConfigurationPropertiesFactoryBean.java index a7f1a5b7..4e9fe02d 100644 --- a/src/main/java/org/apache/commons/configuration2/spring/ConfigurationPropertiesFactoryBean.java +++ b/src/main/java/org/apache/commons/configuration2/spring/ConfigurationPropertiesFactoryBean.java @@ -17,8 +17,8 @@ package org.apache.commons.configuration2.spring; -import java.net.URL; import java.util.Properties; +import java.util.stream.Stream; import org.apache.commons.configuration2.CompositeConfiguration; import org.apache.commons.configuration2.Configuration; @@ -106,16 +106,12 @@ public class ConfigurationPropertiesFactoryBean implements InitializingBean, Fac compositeConfiguration.setThrowExceptionOnMissing(throwExceptionOnMissing); if (configurations != null) { - for (final Configuration configuration : configurations) { - compositeConfiguration.addConfiguration(configuration); - } + Stream.of(configurations).forEach(compositeConfiguration::addConfiguration); } if (locations != null) { for (final Resource location : locations) { - final URL url = location.getURL(); - final Configuration props = new Configurations().properties(url); - compositeConfiguration.addConfiguration(props); + compositeConfiguration.addConfiguration(new Configurations().properties(location.getURL())); } } }