This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 648c5cad Update comment
648c5cad is described below
commit 648c5cad5fbd4bab9c62b5d10822a1983d3f9afc
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Sat Jul 9 18:49:34 2022 -0400
Update comment
---
.../dbcp2/datasources/PooledConnectionManager.java | 134 +++++++++++----------
1 file changed, 68 insertions(+), 66 deletions(-)
diff --git
a/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java
b/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java
index f708f9cc..91efeb11 100644
---
a/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java
+++
b/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java
@@ -1,66 +1,68 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.commons.dbcp2.datasources;
-
-import java.sql.SQLException;
-
-import javax.sql.PooledConnection;
-
-/**
- * Methods to manage PoolableConnections and the connection pools that source
them.
- *
- * @since 2.0
- */
-interface PooledConnectionManager {
-
- /**
- * Closes the connection pool associated with the given user.
- *
- * @param userName
- * user name
- * @throws SQLException
- * if an error occurs closing idle connections in the pool
- */
- void closePool(String userName) throws SQLException;
-
- // /**
- // * Sets the database password used when creating connections.
- // *
- // * @param password password used when authenticating to the database
- // * @since 3.0.0
- // */
- // void setPassword(char[] password);
-
- /**
- * Closes the PooledConnection and remove it from the connection pool to
which it belongs, adjusting pool counters.
- *
- * @param pc
- * PooledConnection to be invalidated
- * @throws SQLException
- * if an SQL error occurs closing the connection
- */
- void invalidate(PooledConnection pc) throws SQLException;
-
- /**
- * Sets the database password used when creating connections.
- *
- * @param password
- * password used when authenticating to the database
- */
- void setPassword(String password);
-
-}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.dbcp2.datasources;
+
+import java.sql.SQLException;
+
+import javax.sql.PooledConnection;
+
+/**
+ * Methods to manage PoolableConnections and the connection pools that source
them.
+ *
+ * @since 2.0
+ */
+interface PooledConnectionManager {
+
+ /**
+ * Closes the connection pool associated with the given user.
+ *
+ * @param userName
+ * user name
+ * @throws SQLException
+ * if an error occurs closing idle connections in the pool
+ */
+ void closePool(String userName) throws SQLException;
+
+ /**
+ * Closes the PooledConnection and remove it from the connection pool to
which it belongs, adjusting pool counters.
+ *
+ * @param pc
+ * PooledConnection to be invalidated
+ * @throws SQLException
+ * if an SQL error occurs closing the connection
+ */
+ void invalidate(PooledConnection pc) throws SQLException;
+
+// /**
+// * Sets the database password used when creating connections.
+// *
+// * @param password password used when authenticating to the database
+// * @since 2.10.0
+// */
+// default void setPassword(char[] password) {
+// setPassword(String.copyValueOf(password));
+// }
+
+ /**
+ * Sets the database password used when creating connections.
+ *
+ * @param password
+ * password used when authenticating to the database
+ */
+ void setPassword(String password);
+
+}
