This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 6bb76f99 For for loop instead of while
6bb76f99 is described below

commit 6bb76f996bc1e8ee2ac7f0e2eaed28702716d507
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Jul 9 08:19:40 2022 -0400

    For for loop instead of while
---
 .../org/apache/commons/compress/archivers/tar/TarArchiveEntry.java   | 5 +----
 .../java/org/apache/commons/compress/harmony/pack200/CpBands.java    | 5 ++---
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
index 01569099..f18a26b7 100644
--- 
a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
+++ 
b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
@@ -35,7 +35,6 @@ import java.util.Collections;
 import java.util.Comparator;
 import java.util.Date;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -849,9 +848,7 @@ public class TarArchiveEntry implements ArchiveEntry, 
TarConstants, EntryStreamO
 
         final List<TarArchiveEntry> entries = new ArrayList<>();
         try (DirectoryStream<Path> dirStream = Files.newDirectoryStream(file)) 
{
-            final Iterator<Path> iterator = dirStream.iterator();
-            while (iterator.hasNext()) {
-                final Path p = iterator.next();
+            for (Path p : dirStream) {
                 entries.add(new TarArchiveEntry(p));
             }
         } catch (final IOException e) {
diff --git 
a/src/main/java/org/apache/commons/compress/harmony/pack200/CpBands.java 
b/src/main/java/org/apache/commons/compress/harmony/pack200/CpBands.java
index 231a1311..d5dfe83f 100644
--- a/src/main/java/org/apache/commons/compress/harmony/pack200/CpBands.java
+++ b/src/main/java/org/apache/commons/compress/harmony/pack200/CpBands.java
@@ -469,7 +469,7 @@ public class CpBands extends BandSet {
             final List cpClasses = new ArrayList();
             CPUTF8 signatureUTF8;
             if (signature.length() > 1 && signature.indexOf('L') != -1) {
-                final List classes = new ArrayList();
+                final List<String> classes = new ArrayList();
                 final char[] chars = signature.toCharArray();
                 final StringBuilder signatureString = new StringBuilder();
                 for (int i = 0; i < chars.length; i++) {
@@ -489,8 +489,7 @@ public class CpBands extends BandSet {
                     }
                 }
                 removeCpUtf8(signature);
-                for (final Iterator iterator2 = classes.iterator(); 
iterator2.hasNext();) {
-                    String className = (String) iterator2.next();
+                for (String className : classes) {
                     CPClass cpClass = null;
                     if (className != null) {
                         className = className.replace('.', '/');

Reply via email to