[commons-io] branch master updated: PMD: ignore empty catch block

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new 9b3c039d PMD: ignore empty catch block
9b3c039d is described below

commit 9b3c039d17a849209be76620eaa361a544a3069e
Author: Gary Gregory <gardgreg...@gmail.com>
AuthorDate: Tue Jun 14 18:16:26 2022 -0400

    PMD: ignore empty catch block
---
 src/main/java/org/apache/commons/io/FileUtils.java                    | 2 +-
 src/main/java/org/apache/commons/io/file/DeletingPathVisitor.java     | 2 +-
 src/main/java/org/apache/commons/io/file/PathUtils.java               | 4 ++--
 .../java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java  | 4 ++--
 src/main/java/org/apache/commons/io/input/ReadAheadInputStream.java   | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/io/FileUtils.java 
b/src/main/java/org/apache/commons/io/FileUtils.java
index c2d8945b..00ca23b8 100644
--- a/src/main/java/org/apache/commons/io/FileUtils.java
+++ b/src/main/java/org/apache/commons/io/FileUtils.java
@@ -1157,7 +1157,7 @@ public class FileUtils {
                             i += 3;
                         } while (i < n && url.charAt(i) == '%');
                         continue;
-                    } catch (final RuntimeException e) {
+                    } catch (final RuntimeException ignored) {
                         // malformed percent-encoded octet, fall through and
                         // append characters literally
                     } finally {
diff --git a/src/main/java/org/apache/commons/io/file/DeletingPathVisitor.java 
b/src/main/java/org/apache/commons/io/file/DeletingPathVisitor.java
index 08c65718..0d3b5334 100644
--- a/src/main/java/org/apache/commons/io/file/DeletingPathVisitor.java
+++ b/src/main/java/org/apache/commons/io/file/DeletingPathVisitor.java
@@ -163,7 +163,7 @@ public class DeletingPathVisitor extends 
CountingPathVisitor {
                 try {
                     // deleteIfExists does not work for this case
                     Files.delete(file);
-                } catch (final NoSuchFileException e) {
+                } catch (final NoSuchFileException ignored) {
                     // ignore
                 }
             }
diff --git a/src/main/java/org/apache/commons/io/file/PathUtils.java 
b/src/main/java/org/apache/commons/io/file/PathUtils.java
index be7e216b..3889b3c8 100644
--- a/src/main/java/org/apache/commons/io/file/PathUtils.java
+++ b/src/main/java/org/apache/commons/io/file/PathUtils.java
@@ -537,7 +537,7 @@ public final class PathUtils {
                 pathCounts.getByteCounter().add(size);
                 return pathCounts;
             }
-        } catch (final AccessDeniedException e) {
+        } catch (final AccessDeniedException ignored) {
             // Ignore and try again below.
         }
         final Path parent = getParent(file);
@@ -1436,7 +1436,7 @@ public final class PathUtils {
             if (setDosReadOnly(path, readOnly, linkOptions)) {
                 return path;
             }
-        } catch (final IOException e) {
+        } catch (final IOException ignored) {
             // Retry with POSIX below.
         }
         final Path parent = getParent(path);
diff --git 
a/src/main/java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java 
b/src/main/java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java
index 7c0b9833..49277729 100644
--- a/src/main/java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java
+++ b/src/main/java/org/apache/commons/io/filefilter/MagicNumberFileFilter.java
@@ -264,7 +264,7 @@ public class MagicNumberFileFilter extends 
AbstractFileFilter implements
                     return Arrays.equals(this.magicNumbers, fileBytes);
                 }
             }
-            catch (final IOException ioe) {
+            catch (final IOException ignored) {
                 // Do nothing, fall through and do not accept file
             }
         }
@@ -301,7 +301,7 @@ public class MagicNumberFileFilter extends 
AbstractFileFilter implements
                     return toFileVisitResult(Arrays.equals(this.magicNumbers, 
byteBuffer.array()));
                 }
             }
-            catch (final IOException ioe) {
+            catch (final IOException ignored) {
                 // Do nothing, fall through and do not accept file
             }
         }
diff --git 
a/src/main/java/org/apache/commons/io/input/ReadAheadInputStream.java 
b/src/main/java/org/apache/commons/io/input/ReadAheadInputStream.java
index dc3f8fcb..3a685d7e 100644
--- a/src/main/java/org/apache/commons/io/input/ReadAheadInputStream.java
+++ b/src/main/java/org/apache/commons/io/input/ReadAheadInputStream.java
@@ -227,8 +227,8 @@ public class ReadAheadInputStream extends InputStream {
         if (needToCloseUnderlyingInputStream) {
             try {
                 underlyingInputStream.close();
-            } catch (final IOException e) {
-                // TODO ?
+            } catch (final IOException ignored) {
+                // TODO Rethrow as UncheckedIOException?
             }
         }
     }