This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
The following commit(s) were added to refs/heads/master by this push:
new ec97b35a Remove noisy inline comments.
ec97b35a is described below
commit ec97b35a84a8760004328a29295938e2b0cc6162
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue May 31 11:30:07 2022 -0400
Remove noisy inline comments.
---
.../apache/commons/imaging/formats/png/PngImageParser.java | 2 --
.../apache/commons/imaging/formats/tiff/TiffImageParser.java | 6 ------
.../imaging/formats/tiff/datareaders/DataReaderStrips.java | 1 -
.../imaging/formats/tiff/write/TiffOutputDirectory.java | 12 ------------
.../apache/commons/imaging/formats/xmp/XmpUpdateTest.java | 2 --
5 files changed, 23 deletions(-)
diff --git
a/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
b/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
index 90a1884b..91a6f884 100644
--- a/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/png/PngImageParser.java
@@ -520,8 +520,6 @@ public class PngImageParser extends
ImageParser<PngImagingParameters> implement
pngChunkPLTE = (PngChunkPlte) PLTEs.get(0);
}
- // -----
-
final List<PngChunk> IDATs = filterChunks(chunks, ChunkType.IDAT);
if (IDATs.isEmpty()) {
throw new ImageReadException("PNG missing image data");
diff --git
a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
index 2e89afc6..1665907f 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java
@@ -178,8 +178,6 @@ public class TiffImageParser extends
ImageParser<TiffImagingParameters> implemen
final int height = heightField.getIntValue();
final int width = widthField.getIntValue();
- // -------------------
-
final TiffField resolutionUnitField = directory.findField(
TiffTagConstants.TIFF_TAG_RESOLUTION_UNIT);
int resolutionUnit = 2; // Inch
@@ -228,8 +226,6 @@ public class TiffImageParser extends
ImageParser<TiffImagingParameters> implemen
}
}
- // -------------------
-
final TiffField bitsPerSampleField =
directory.findField(TiffTagConstants.TIFF_TAG_BITS_PER_SAMPLE);
int bitsPerSample = 1;
@@ -241,8 +237,6 @@ public class TiffImageParser extends
ImageParser<TiffImagingParameters> implemen
final int bitsPerPixel = bitsPerSample; // assume grayscale;
// dunno if this handles colormapped images correctly.
- // -------------------
-
final List<TiffField> entries = directory.entries;
final List<String> comments = new ArrayList<>(entries.size());
for (final TiffField field : entries) {
diff --git
a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
index 770587fe..2cd4b87f 100644
---
a/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
+++
b/src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
@@ -213,7 +213,6 @@ public final class DataReaderStrips extends ImageDataReader
{
return;
}
- // ------------------------------------------------------------
// original code before May 2012 modification
// this logic will handle all cases not conforming to the
// special case handled above
diff --git
a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputDirectory.java
b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputDirectory.java
index a26916e3..b3e3995a 100644
---
a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputDirectory.java
+++
b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputDirectory.java
@@ -688,8 +688,6 @@ public final class TiffOutputDirectory extends
TiffOutputItem {
}
- // --------------------------------------------------------------
-
removeFieldIfPresent(TiffTagConstants.TIFF_TAG_STRIP_OFFSETS);
removeFieldIfPresent(TiffTagConstants.TIFF_TAG_STRIP_BYTE_COUNTS);
removeFieldIfPresent(TiffTagConstants.TIFF_TAG_TILE_OFFSETS);
@@ -710,8 +708,6 @@ public final class TiffOutputDirectory extends
TiffOutputItem {
byteCountsTag = TiffTagConstants.TIFF_TAG_TILE_BYTE_COUNTS;
}
- // --------
-
final TiffElement.DataElement[] imageData =
tiffImageData.getImageData();
// TiffOutputField imageDataOffsetsField = null;
@@ -722,8 +718,6 @@ public final class TiffOutputDirectory extends
TiffOutputItem {
imageDataByteCounts[i] = imageData[i].length;
}
- // --------
-
// Append imageData-related fields to first directory
imageDataOffsetField = new TiffOutputField(offsetTag,
FieldType.LONG, imageDataOffsets.length,
@@ -731,21 +725,15 @@ public final class TiffOutputDirectory extends
TiffOutputItem {
outputSummary.byteOrder));
add(imageDataOffsetField);
- // --------
-
final byte[] data = FieldType.LONG.writeData(imageDataByteCounts,
outputSummary.byteOrder);
final TiffOutputField byteCountsField = new TiffOutputField(
byteCountsTag, FieldType.LONG, imageDataByteCounts.length,
data);
add(byteCountsField);
- // --------
-
imageDataInfo = new ImageDataOffsets(imageData, imageDataOffsets,
imageDataOffsetField);
}
- // --------------------------------------------------------------
-
final List<TiffOutputItem> result = new ArrayList<>();
result.add(this);
sortFields();
diff --git
a/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
b/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
index 45ad49d5..fd62e03f 100644
--- a/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
+++ b/src/test/java/org/apache/commons/imaging/formats/xmp/XmpUpdateTest.java
@@ -67,8 +67,6 @@ public class XmpUpdateTest extends ImagingTest {
final File tempFile = File.createTempFile(imageFile.getName() +
".", "." + imageFormat.getDefaultExtension());
final BufferedImage image = Imaging.getBufferedImage(imageFile);
- // ----
-
final ImageParser parser = Util.getImageParser("." +
imageFormat.getDefaultExtension());
final ImagingParameters params = parser.getDefaultParameters();
((XmpImagingParameters) params).setXmpXml(xmpXml);
