[commons-lang] branch master updated: Remove unnecessary variable creations. (#882)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new ba08d40be Remove unnecessary variable creations. (#882)
ba08d40be is described below

commit ba08d40bebcf5c05f800e14138364ac118f20e97
Author: Arturo Bernal <arturobern...@gmail.com>
AuthorDate: Mon May 2 15:33:50 2022 +0200

    Remove unnecessary variable creations. (#882)
---
 .../java/org/apache/commons/lang3/text/ExtendedMessageFormat.java    | 5 ++---
 src/main/java/org/apache/commons/lang3/text/StrBuilder.java          | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git 
a/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java 
b/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
index 4a6647101..0afa25253 100644
--- a/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
+++ b/src/main/java/org/apache/commons/lang3/text/ExtendedMessageFormat.java
@@ -493,12 +493,11 @@ public class ExtendedMessageFormat extends MessageFormat {
 
         final int start = pos.getIndex();
         final char[] c = pattern.toCharArray();
-        final int lastHold = start;
         for (int i = pos.getIndex(); i < pattern.length(); i++) {
             if (c[pos.getIndex()] == QUOTE) {
                 next(pos);
-                return appendTo == null ? null : appendTo.append(c, lastHold,
-                        pos.getIndex() - lastHold);
+                return appendTo == null ? null : appendTo.append(c, start,
+                        pos.getIndex() - start);
             }
             next(pos);
         }
diff --git a/src/main/java/org/apache/commons/lang3/text/StrBuilder.java 
b/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
index 6a617ac02..22c92755d 100644
--- a/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
+++ b/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
@@ -205,9 +205,8 @@ public class StrBuilder implements CharSequence, 
Appendable, Serializable, Build
         } else if (length > size) {
             ensureCapacity(length);
             final int oldEnd = size;
-            final int newEnd = length;
             size = length;
-            for (int i = oldEnd; i < newEnd; i++) {
+            for (int i = oldEnd; i < length; i++) {
                 buffer[i] = CharUtils.NUL;
             }
         }