This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


    from bc3bf60b Quiet please.
     new 256386cc Sort members.
     new 9f188870 Add spotbugs:check to the default Maven goal. Revert "Add 
spotbugs:check to the default Maven goal."
     new 58664a05 Update Spotbugs plugin and tool to 4.6.0.0/4.6.0
     new 94d31f8e Fix SpotBugs [ERROR] High: Found reliance on default encoding
     new 4e36acdf Remove unused exception from private method signature.
     new 2bf42c41 Remove unused exception from signature.
     new db3b0e1f Use camel-case.
     new 5a4b4fc1 Fix SpotBugs [ERROR] High: Found reliance on default encoding

The 8 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 pom.xml                                            |    4 +-
 src/changes/changes.xml                            |    2 +
 src/main/java/org/apache/bcel/Const.java           |  290 ++--
 src/main/java/org/apache/bcel/ExceptionConst.java  |   52 +-
 src/main/java/org/apache/bcel/Repository.java      |  226 +--
 .../org/apache/bcel/classfile/AccessFlags.java     |  176 +-
 .../apache/bcel/classfile/AnnotationDefault.java   |   28 +-
 .../bcel/classfile/AnnotationElementValue.java     |   10 +-
 .../org/apache/bcel/classfile/AnnotationEntry.java |   88 +-
 .../org/apache/bcel/classfile/Annotations.java     |   60 +-
 .../apache/bcel/classfile/ArrayElementValue.java   |   46 +-
 .../org/apache/bcel/classfile/BootstrapMethod.java |   64 +-
 .../apache/bcel/classfile/BootstrapMethods.java    |   28 +-
 .../apache/bcel/classfile/ClassElementValue.java   |   18 +-
 .../org/apache/bcel/classfile/ClassParser.java     |    2 +-
 src/main/java/org/apache/bcel/classfile/Code.java  |  158 +-
 .../org/apache/bcel/classfile/CodeException.java   |   46 +-
 .../java/org/apache/bcel/classfile/Constant.java   |  138 +-
 .../java/org/apache/bcel/classfile/ConstantCP.java |   40 +-
 .../org/apache/bcel/classfile/ConstantClass.java   |   30 +-
 .../org/apache/bcel/classfile/ConstantDouble.java  |   34 +-
 .../org/apache/bcel/classfile/ConstantFloat.java   |   34 +-
 .../org/apache/bcel/classfile/ConstantInteger.java |   34 +-
 .../org/apache/bcel/classfile/ConstantLong.java    |   34 +-
 .../bcel/classfile/ConstantMethodHandle.java       |   16 +-
 .../org/apache/bcel/classfile/ConstantModule.java  |   30 +-
 .../apache/bcel/classfile/ConstantNameAndType.java |   20 +-
 .../org/apache/bcel/classfile/ConstantPackage.java |   30 +-
 .../org/apache/bcel/classfile/ConstantPool.java    |   96 +-
 .../org/apache/bcel/classfile/ConstantString.java  |   32 +-
 .../org/apache/bcel/classfile/ConstantValue.java   |   22 +-
 .../java/org/apache/bcel/classfile/Deprecated.java |   30 +-
 .../apache/bcel/classfile/DescendingVisitor.java   |  512 +++---
 .../org/apache/bcel/classfile/ElementValue.java    |   70 +-
 .../apache/bcel/classfile/ElementValuePair.java    |   20 +-
 .../org/apache/bcel/classfile/EmptyVisitor.java    |  176 +-
 .../org/apache/bcel/classfile/EnclosingMethod.java |   36 +-
 .../apache/bcel/classfile/EnumElementValue.java    |   20 +-
 .../org/apache/bcel/classfile/ExceptionTable.java  |   74 +-
 src/main/java/org/apache/bcel/classfile/Field.java |  122 +-
 .../org/apache/bcel/classfile/FieldOrMethod.java   |  204 +--
 .../java/org/apache/bcel/classfile/InnerClass.java |   44 +-
 .../org/apache/bcel/classfile/InnerClasses.java    |   58 +-
 .../java/org/apache/bcel/classfile/JavaClass.java  |  914 +++++-----
 .../java/org/apache/bcel/classfile/LineNumber.java |   46 +-
 .../org/apache/bcel/classfile/LineNumberTable.java |  132 +-
 .../org/apache/bcel/classfile/LocalVariable.java   |  114 +-
 .../apache/bcel/classfile/LocalVariableTable.java  |   92 +-
 .../bcel/classfile/LocalVariableTypeTable.java     |   66 +-
 .../java/org/apache/bcel/classfile/Method.java     |  184 +-
 .../org/apache/bcel/classfile/MethodParameter.java |   74 +-
 .../apache/bcel/classfile/MethodParameters.java    |   16 +-
 .../java/org/apache/bcel/classfile/Module.java     |  116 +-
 .../org/apache/bcel/classfile/ModuleExports.java   |   26 +-
 .../org/apache/bcel/classfile/ModuleMainClass.java |   48 +-
 .../org/apache/bcel/classfile/ModuleOpens.java     |   26 +-
 .../org/apache/bcel/classfile/ModulePackages.java  |   78 +-
 .../org/apache/bcel/classfile/ModuleProvides.java  |   26 +-
 .../org/apache/bcel/classfile/ModuleRequires.java  |   26 +-
 .../java/org/apache/bcel/classfile/NestHost.java   |   48 +-
 .../org/apache/bcel/classfile/NestMembers.java     |   82 +-
 .../java/org/apache/bcel/classfile/PMGClass.java   |   66 +-
 .../bcel/classfile/ParameterAnnotationEntry.java   |   38 +-
 .../bcel/classfile/ParameterAnnotations.java       |   44 +-
 .../java/org/apache/bcel/classfile/Signature.java  |  275 +--
 .../apache/bcel/classfile/SimpleElementValue.java  |  118 +-
 .../java/org/apache/bcel/classfile/SourceFile.java |   48 +-
 .../java/org/apache/bcel/classfile/StackMap.java   |   90 +-
 .../org/apache/bcel/classfile/StackMapEntry.java   |  264 +--
 .../org/apache/bcel/classfile/StackMapType.java    |  104 +-
 .../java/org/apache/bcel/classfile/Synthetic.java  |   48 +-
 .../java/org/apache/bcel/classfile/Unknown.java    |   52 +-
 .../java/org/apache/bcel/classfile/Utility.java    | 1254 +++++++-------
 .../java/org/apache/bcel/classfile/Visitor.java    |  162 +-
 .../java/org/apache/bcel/generic/ACONST_NULL.java  |   16 +-
 .../java/org/apache/bcel/generic/ANEWARRAY.java    |   14 +-
 .../java/org/apache/bcel/generic/ARRAYLENGTH.java  |   20 +-
 src/main/java/org/apache/bcel/generic/ATHROW.java  |   20 +-
 .../bcel/generic/AnnotationElementValueGen.java    |   24 +-
 .../apache/bcel/generic/AnnotationEntryGen.java    |  302 ++--
 .../apache/bcel/generic/ArrayElementValueGen.java  |   68 +-
 .../java/org/apache/bcel/generic/ArrayType.java    |   38 +-
 src/main/java/org/apache/bcel/generic/BIPUSH.java  |   54 +-
 .../java/org/apache/bcel/generic/BasicType.java    |   36 +-
 .../java/org/apache/bcel/generic/BranchHandle.java |   74 +-
 .../org/apache/bcel/generic/BranchInstruction.java |  220 +--
 .../java/org/apache/bcel/generic/CHECKCAST.java    |   38 +-
 .../org/apache/bcel/generic/CPInstruction.java     |   66 +-
 .../apache/bcel/generic/ClassElementValueGen.java  |   62 +-
 .../java/org/apache/bcel/generic/ClassGen.java     |  642 +++----
 .../org/apache/bcel/generic/CodeExceptionGen.java  |  126 +-
 .../org/apache/bcel/generic/ConstantPoolGen.java   |  762 ++++-----
 src/main/java/org/apache/bcel/generic/DCMPG.java   |   14 +-
 src/main/java/org/apache/bcel/generic/DCMPL.java   |   14 +-
 src/main/java/org/apache/bcel/generic/DCONST.java  |   28 +-
 .../org/apache/bcel/generic/ElementValueGen.java   |  128 +-
 .../apache/bcel/generic/ElementValuePairGen.java   |   20 +-
 .../java/org/apache/bcel/generic/EmptyVisitor.java |  366 ++--
 .../apache/bcel/generic/EnumElementValueGen.java   |   78 +-
 src/main/java/org/apache/bcel/generic/FCMPG.java   |   16 +-
 src/main/java/org/apache/bcel/generic/FCMPL.java   |   16 +-
 src/main/java/org/apache/bcel/generic/FCONST.java  |   28 +-
 .../java/org/apache/bcel/generic/FieldGen.java     |  348 ++--
 .../apache/bcel/generic/FieldGenOrMethodGen.java   |  132 +-
 .../org/apache/bcel/generic/FieldInstruction.java  |   32 +-
 .../org/apache/bcel/generic/FieldOrMethod.java     |   66 +-
 .../java/org/apache/bcel/generic/GETFIELD.java     |   28 +-
 .../java/org/apache/bcel/generic/GETSTATIC.java    |   26 +-
 src/main/java/org/apache/bcel/generic/GOTO.java    |   36 +-
 src/main/java/org/apache/bcel/generic/GOTO_W.java  |   34 +-
 .../org/apache/bcel/generic/GotoInstruction.java   |   10 +-
 src/main/java/org/apache/bcel/generic/ICONST.java  |   28 +-
 src/main/java/org/apache/bcel/generic/IDIV.java    |   20 +-
 src/main/java/org/apache/bcel/generic/IFEQ.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFGE.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFGT.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFLE.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFLT.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFNE.java    |   18 +-
 .../java/org/apache/bcel/generic/IFNONNULL.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IFNULL.java  |   18 +-
 .../java/org/apache/bcel/generic/IF_ACMPEQ.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ACMPNE.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPEQ.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPGE.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPGT.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPLE.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPLT.java    |   18 +-
 .../java/org/apache/bcel/generic/IF_ICMPNE.java    |   18 +-
 src/main/java/org/apache/bcel/generic/IINC.java    |   94 +-
 .../java/org/apache/bcel/generic/INSTANCEOF.java   |   32 +-
 .../org/apache/bcel/generic/INVOKEDYNAMIC.java     |   88 +-
 .../org/apache/bcel/generic/INVOKEINTERFACE.java   |   76 +-
 .../org/apache/bcel/generic/INVOKESPECIAL.java     |   40 +-
 .../java/org/apache/bcel/generic/INVOKESTATIC.java |   36 +-
 .../org/apache/bcel/generic/INVOKEVIRTUAL.java     |   40 +-
 src/main/java/org/apache/bcel/generic/IREM.java    |   20 +-
 .../java/org/apache/bcel/generic/Instruction.java  |  318 ++--
 .../org/apache/bcel/generic/InstructionConst.java  |    4 +-
 .../apache/bcel/generic/InstructionConstants.java  |  226 +--
 .../apache/bcel/generic/InstructionFactory.java    |  818 ++++-----
 .../org/apache/bcel/generic/InstructionHandle.java |  292 ++--
 .../org/apache/bcel/generic/InstructionList.java   | 1462 ++++++++--------
 .../org/apache/bcel/generic/InvokeInstruction.java |   84 +-
 src/main/java/org/apache/bcel/generic/JSR.java     |   36 +-
 src/main/java/org/apache/bcel/generic/JSR_W.java   |   34 +-
 .../org/apache/bcel/generic/JsrInstruction.java    |   10 +-
 src/main/java/org/apache/bcel/generic/LCMP.java    |   16 +-
 src/main/java/org/apache/bcel/generic/LCONST.java  |   28 +-
 src/main/java/org/apache/bcel/generic/LDC.java     |  104 +-
 src/main/java/org/apache/bcel/generic/LDC2_W.java  |   36 +-
 src/main/java/org/apache/bcel/generic/LDIV.java    |   16 +-
 .../java/org/apache/bcel/generic/LOOKUPSWITCH.java |   36 +-
 src/main/java/org/apache/bcel/generic/LREM.java    |   16 +-
 .../org/apache/bcel/generic/LineNumberGen.java     |   54 +-
 .../org/apache/bcel/generic/LocalVariableGen.java  |  174 +-
 .../bcel/generic/LocalVariableInstruction.java     |  134 +-
 .../java/org/apache/bcel/generic/MONITORENTER.java |   16 +-
 .../java/org/apache/bcel/generic/MONITOREXIT.java  |   16 +-
 .../org/apache/bcel/generic/MULTIANEWARRAY.java    |   96 +-
 .../java/org/apache/bcel/generic/MethodGen.java    | 1408 +++++++--------
 src/main/java/org/apache/bcel/generic/NEW.java     |   28 +-
 .../java/org/apache/bcel/generic/NEWARRAY.java     |   60 +-
 .../bcel/generic/NameSignatureInstruction.java     |   16 +-
 .../java/org/apache/bcel/generic/ObjectType.java   |   82 +-
 src/main/java/org/apache/bcel/generic/PUSH.java    |  118 +-
 .../java/org/apache/bcel/generic/PUTFIELD.java     |   28 +-
 .../java/org/apache/bcel/generic/PUTSTATIC.java    |   26 +-
 src/main/java/org/apache/bcel/generic/RET.java     |   76 +-
 .../org/apache/bcel/generic/ReferenceType.java     |  288 ++--
 .../org/apache/bcel/generic/ReturnInstruction.java |   16 +-
 .../org/apache/bcel/generic/ReturnaddressType.java |   22 +-
 src/main/java/org/apache/bcel/generic/SIPUSH.java  |   54 +-
 src/main/java/org/apache/bcel/generic/SWITCH.java  |   58 +-
 src/main/java/org/apache/bcel/generic/Select.java  |  300 ++--
 .../apache/bcel/generic/SimpleElementValueGen.java |  104 +-
 .../java/org/apache/bcel/generic/TABLESWITCH.java  |   36 +-
 src/main/java/org/apache/bcel/generic/Type.java    |  392 ++---
 src/main/java/org/apache/bcel/generic/Visitor.java |  366 ++--
 .../bcel/util/AbstractClassPathRepository.java     |   66 +-
 .../java/org/apache/bcel/util/AttributeHTML.java   |   81 +-
 .../java/org/apache/bcel/util/BCELFactory.java     |  272 +--
 src/main/java/org/apache/bcel/util/BCELifier.java  |  288 ++--
 .../java/org/apache/bcel/util/ByteSequence.java    |   36 +-
 src/main/java/org/apache/bcel/util/Class2HTML.java |  169 +-
 .../java/org/apache/bcel/util/ClassLoader.java     |   88 +-
 .../apache/bcel/util/ClassLoaderRepository.java    |   50 +-
 .../org/apache/bcel/util/ClassPathRepository.java  |   26 +-
 src/main/java/org/apache/bcel/util/ClassQueue.java |   10 +-
 src/main/java/org/apache/bcel/util/ClassSet.java   |   18 +-
 src/main/java/org/apache/bcel/util/ClassStack.java |   12 +-
 src/main/java/org/apache/bcel/util/CodeHTML.java   |   55 +-
 .../java/org/apache/bcel/util/ConstantHTML.java    |   61 +-
 .../org/apache/bcel/util/InstructionFinder.java    |  414 ++---
 .../java/org/apache/bcel/util/JavaWrapper.java     |   46 +-
 .../bcel/util/LruCacheClassPathRepository.java     |   16 +-
 .../util/MemorySensitiveClassPathRepository.java   |   32 +-
 src/main/java/org/apache/bcel/util/MethodHTML.java |   51 +-
 .../org/apache/bcel/util/ModularRuntimeImage.java  |   13 +-
 src/main/java/org/apache/bcel/util/Repository.java |   26 +-
 .../org/apache/bcel/util/SyntheticRepository.java  |    8 +-
 .../apache/bcel/verifier/GraphicalVerifier.java    |   22 +-
 .../org/apache/bcel/verifier/NativeVerifier.java   |   14 +-
 .../org/apache/bcel/verifier/PassVerifier.java     |   50 +-
 .../org/apache/bcel/verifier/TransitiveHull.java   |   46 +-
 .../apache/bcel/verifier/VerificationResult.java   |   30 +-
 .../java/org/apache/bcel/verifier/Verifier.java    |  168 +-
 .../org/apache/bcel/verifier/VerifierAppFrame.java |  206 +--
 .../org/apache/bcel/verifier/VerifierFactory.java  |   38 +-
 .../bcel/verifier/VerifierFactoryListModel.java    |   36 +-
 .../org/apache/bcel/verifier/VerifyDialog.java     |  134 +-
 .../verifier/exc/AssertionViolatedException.java   |   18 +-
 .../exc/StructuralCodeConstraintException.java     |   10 +-
 .../java/org/apache/bcel/verifier/exc/Utility.java |    6 +-
 .../apache/bcel/verifier/statics/DOUBLE_Upper.java |   10 +-
 .../apache/bcel/verifier/statics/LONG_Upper.java   |   10 +-
 .../bcel/verifier/statics/LocalVariableInfo.java   |   90 +-
 .../bcel/verifier/statics/LocalVariablesInfo.java  |   26 +-
 .../bcel/verifier/statics/Pass1Verifier.java       |   36 +-
 .../bcel/verifier/statics/Pass2Verifier.java       | 1792 ++++++++++----------
 .../bcel/verifier/statics/Pass3aVerifier.java      | 1654 +++++++++---------
 .../verifier/statics/StringRepresentation.java     |  188 +-
 .../verifier/structurals/ControlFlowGraph.java     |  302 ++--
 .../verifier/structurals/ExecutionVisitor.java     |   16 +-
 .../apache/bcel/verifier/structurals/Frame.java    |   56 +-
 .../structurals/InstConstraintVisitor.java         |  610 +++----
 .../verifier/structurals/InstructionContext.java   |   60 +-
 .../bcel/verifier/structurals/LocalVariables.java  |  102 +-
 .../bcel/verifier/structurals/OperandStack.java    |  132 +-
 .../bcel/verifier/structurals/Pass3bVerifier.java  |   64 +-
 .../bcel/verifier/structurals/Subroutine.java      |   48 +-
 .../bcel/verifier/structurals/Subroutines.java     |  456 ++---
 .../structurals/UninitializedObjectType.java       |   26 +-
 .../bcel/AbstractCounterVisitorTestCase.java       |   16 +-
 .../java/org/apache/bcel/AbstractTestCase.java     |  166 +-
 .../org/apache/bcel/AnonymousClassTestCase.java    |   26 +-
 .../org/apache/bcel/CounterVisitorTestCase.java    |   12 +-
 .../org/apache/bcel/ElementValueGenTestCase.java   |  152 +-
 .../bcel/EnclosingMethodAttributeTestCase.java     |   46 +-
 .../bcel/LocalVariableTypeTableTestCase.java       |   82 +-
 src/test/java/org/apache/bcel/NanoTimer.java       |    8 +-
 src/test/java/org/apache/bcel/PLSETestCase.java    |   38 +-
 .../bcel/classfile/ConstantPoolTestCase.java       |   12 +-
 .../bcel/classfile/JDKClassDumpTestCase.java       |   50 +-
 .../bcel/data/AnnotatedWithCombinedAnnotation.java |    8 +-
 .../org/apache/bcel/data/AnonymousClassTest.java   |   16 +-
 .../apache/bcel/data/AttributeTestClassEM02.java   |    8 +-
 .../org/apache/bcel/data/ComplexAnnotation.java    |   12 +-
 .../java/org/apache/bcel/data/ConstantPoolX.java   |   56 +-
 .../org/apache/bcel/data/SimpleAnnotation.java     |    4 +-
 .../apache/bcel/generic/AnnotationGenTestCase.java |   50 +-
 .../apache/bcel/generic/BranchHandleTestCase.java  |   14 +-
 .../bcel/generic/FieldAnnotationsTestCase.java     |   52 +-
 .../GeneratingAnnotatedClassesTestCase.java        |  654 +++----
 .../bcel/generic/InstructionHandleTestCase.java    |   28 +-
 .../bcel/generic/JdkGenericDumpTestCase.java       |   40 +-
 .../org/apache/bcel/generic/MethodGenTestCase.java |   36 +-
 .../org/apache/bcel/util/Class2HTMLTestCase.java   |    3 +-
 .../bcel/util/ClassPathRepositoryTestCase.java     |   72 +-
 .../bcel/util/ModularRuntimeImageTestCase.java     |   16 +-
 .../bcel/verifier/VerifierInvokeTestCase.java      |   20 +-
 .../bcel/verifier/VerifyBadClassesTestCase.java    |  140 +-
 .../apache/bcel/verifier/tests/TestArray01.java    |    8 +-
 .../apache/bcel/verifier/tests/TestCreator.java    |   20 +-
 .../verifier/tests/TestLegalInvokeInterface01.java |    8 +-
 .../apache/bcel/verifier/tests/TestReturn02.java   |   16 +-
 .../org/apache/bcel/visitors/CounterVisitor.java   |  192 +--
 267 files changed, 15291 insertions(+), 15283 deletions(-)

Reply via email to