[commons-rng] 01/03: Compute p-value for the chi square test once.

[aherbert]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git

commit 52a5b802ca01d1b5924da3939e1392413939cd96
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Tue Mar 1 23:58:32 2022 +0000

    Compute p-value for the chi square test once.
    
    Use String.format for the assertion message.
---
 .../distribution/DiscreteSamplerParametricTest.java         | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git 
a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
 
b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
index 731d3f0..cafe3cb 100644
--- 
a/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
+++ 
b/commons-rng-sampling/src/test/java/org/apache/commons/rng/sampling/distribution/DiscreteSamplerParametricTest.java
@@ -85,8 +85,9 @@ class DiscreteSamplerParametricTest {
                     }
                 }
 
-                if (chiSquareTest.chiSquareTest(expected, observed, 0.01)) {
-                    failedStat.add(chiSquareTest.chiSquareTest(expected, 
observed));
+                final double p = chiSquareTest.chiSquareTest(expected, 
observed);
+                if (p < 0.01) {
+                    failedStat.add(p);
                     ++numFailures;
                 }
             }
@@ -104,9 +105,11 @@ class DiscreteSamplerParametricTest {
         // 3     0.0016
 
         if (numFailures > 3) { // Test will fail with 0.16% probability
-            Assertions.fail(sampler + ": Too many failures for sample size = " 
+ sampleSize +
-                            " (" + numFailures + " out of " + numTests + " 
tests failed, " +
-                            "chi2=" + Arrays.toString(failedStat.toArray(new 
Double[0])));
+            Assertions.fail(String.format(
+                    "%s: Too many failures for sample size = %d " +
+                    " (%d out of %d tests failed, chi2=%s",
+                    sampler, sampleSize, numFailures, numTests,
+                    Arrays.toString(failedStat.toArray(new Double[0]))));
         }
     }
 }